Re: Possible minibuffer completion enhancements

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

Eshel Yaron <me@eshelyaron.com> writes:

> Eshel Yaron <me@eshelyaron.com> writes:
>
>> All right, I've created a new feature branch called
>> feature/minibuffer-completion-enhancements that you can find at:
>>
>> git clone -b feature/minibuffer-completion-enhancements https://git.sr.ht/~eshel/emacs
>>
>> I've also requested access to push this branch to emacs.git on Savannah,
>> so people won't need to fetch from another Git remote to test it.
>
> I've rebased the feature/minibuffer-completion-enhancements branch on
> top of the current master, and pushed it to emacs.git.  Looking forward
> for your thoughts and feedback!

I like the improvements, they are not invasive but useful.  C-o is
particularly nice.

One annoyance I had with `completions-auto-update-mode' was that it
didn't update the buffer on deleting a character.  This should fix it,
but perhaps it can be optimised further by using `after-change-functions'?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pch.diff --]
[-- Type: text/x-diff, Size: 731 bytes --]

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 0f503523817..6b949d67ec1 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -5804,12 +5804,12 @@ completions-auto-update-start-timer
 
 (defun completions-auto-update-setup ()
   "Prepare for updating *Completions* as you type in the minibuffer."
-  (add-hook 'post-self-insert-hook
+  (add-hook 'post-command-hook
             #'completions-auto-update-start-timer nil t))
 
 (defun completions-auto-update-exit ()
   "Stop updating *Completions* as you type in the minibuffer."
-  (remove-hook 'post-self-insert-hook
+  (remove-hook 'post-command-hook
                #'completions-auto-update-start-timer t))
 
 (define-minor-mode completions-auto-update-mode