From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Possible minibuffer completion enhancements Date: Mon, 22 Jan 2024 21:11:54 +0000 Message-ID: <87plxtnkdh.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 22 22:12:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rS1b3-0007YK-F0 for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jan 2024 22:12:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rS1aO-0004kg-V7; Mon, 22 Jan 2024 16:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rS1aK-0004j1-LP for emacs-devel@gnu.org; Mon, 22 Jan 2024 16:12:00 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rS1aH-00021H-VM for emacs-devel@gnu.org; Mon, 22 Jan 2024 16:12:00 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2D8FD240103 for ; Mon, 22 Jan 2024 22:11:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705957915; bh=QdEDYUnHp3gOLjz2aPSM+vdBFv3czkmtWoK5GLRNCQI=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=dQewpFNOdHCFwCr1BWeTP1EAmCudZgO85yCmGqQKiA2SNsGAIxSGXfgvHTs12Ouuu fx/sQgNPhr62yYwcMiBb4V9oyelgRA1RGvRTVGpZNNi7mixWnHlqNft02fKgwLjoat J7OkSoRqd/TUSVeHK9JgHIaycHV2ipxYtQdgCLvL3lBuIMKTAQaf/saWDNiKTXmXUq A3slxccltfDRqZtr316ywKHbx6fCuEFAm/JcoJyxmmaZ2SI2oJBhRKrr6kPXqpzAvo 9z0ZTl4QrL8n3KkGBbI2Io0upWPISIz3vY6BuPQUTHD1lwVlcOD+Ed4cpxaTR+NQQc RMrg2Exx5lkog== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TJjZy3mSmz6tyr; Mon, 22 Jan 2024 22:11:54 +0100 (CET) In-Reply-To: (Eshel Yaron's message of "Sun, 21 Jan 2024 10:03:54 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315226 Archived-At: --=-=-= Content-Type: text/plain Eshel Yaron writes: > Eshel Yaron writes: > >> All right, I've created a new feature branch called >> feature/minibuffer-completion-enhancements that you can find at: >> >> git clone -b feature/minibuffer-completion-enhancements https://git.sr.ht/~eshel/emacs >> >> I've also requested access to push this branch to emacs.git on Savannah, >> so people won't need to fetch from another Git remote to test it. > > I've rebased the feature/minibuffer-completion-enhancements branch on > top of the current master, and pushed it to emacs.git. Looking forward > for your thoughts and feedback! I like the improvements, they are not invasive but useful. C-o is particularly nice. One annoyance I had with `completions-auto-update-mode' was that it didn't update the buffer on deleting a character. This should fix it, but perhaps it can be optimised further by using `after-change-functions'? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=pch.diff diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 0f503523817..6b949d67ec1 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -5804,12 +5804,12 @@ completions-auto-update-start-timer (defun completions-auto-update-setup () "Prepare for updating *Completions* as you type in the minibuffer." - (add-hook 'post-self-insert-hook + (add-hook 'post-command-hook #'completions-auto-update-start-timer nil t)) (defun completions-auto-update-exit () "Stop updating *Completions* as you type in the minibuffer." - (remove-hook 'post-self-insert-hook + (remove-hook 'post-command-hook #'completions-auto-update-start-timer t)) (define-minor-mode completions-auto-update-mode --=-=-=--