From: "João Távora" <joaotavora@gmail.com>
To: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Should (icomplete-mode) explicitly disable fido-mode?
Date: Fri, 05 Jun 2020 23:48:38 +0100 [thread overview]
Message-ID: <87o8pxjfi1.fsf@gmail.com> (raw)
In-Reply-To: <7ADEE954-6074-4C8E-9EB7-7BF93F6F46BD@schwartzmeyer.com> (Andrew Schwartzmeyer's message of "Thu, 4 Jun 2020 10:49:05 -0700")
Andrew Schwartzmeyer <andrew@schwartzmeyer.com> writes:
> icomplete-vertical calls (icomplete-mode), I think expecting it to be
> idempotent (not have any effect if icomplete-mode is already enabled),
> but in fact, since fido-mode is currently enabled this explicitly
> disables it and switches to the base icomplete-mode, as the mode
> functions icomplete-mode and fido-mode act like toggles of each
> other.
But isn't the end result what icomplete-vertical is after?
i.e. icomplete with some kind of verticality added? Or were you
expecting icomplete-vertical to add verticality to fido-mode?
> Should (icomplete-mode t) perhaps do nothing if fido-mode is already
> enabled?
Maybe.
> I’m not sure. Obviously the package can workaround it (given
> my patch), but I think it’s unexpected to have to avoid calling
> (icomplete-mode) if the icomplete-mode var is already t. What do you
> think?
It's a tricky situation, indeed. Fido-mode sets the icomplete-mode
variable for effects, i.e. to have some functions that check that
variable behave differently. But tries not to "be" icomplete-mode.
Maybe Stefan Monnier would have something to say about this
João
next prev parent reply other threads:[~2020-06-05 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:49 Should (icomplete-mode) explicitly disable fido-mode? Andrew Schwartzmeyer
2020-06-05 22:48 ` João Távora [this message]
2020-06-05 23:19 ` Stefan Monnier
2020-06-06 5:14 ` Andrew Schwartzmeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8pxjfi1.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=andrew@schwartzmeyer.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).