unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Should (icomplete-mode) explicitly disable fido-mode?
Date: Fri, 5 Jun 2020 22:14:44 -0700	[thread overview]
Message-ID: <4F21BA4E-0725-46D5-80D2-CBB96ADBF45A@schwartzmeyer.com> (raw)
In-Reply-To: <87o8pxjfi1.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Jun 5, 2020, at 3:48 PM, João Távora <joaotavora@gmail.com> wrote:
> 
> But isn't the end result what icomplete-vertical is after?
> i.e. icomplete with some kind of verticality added?  Or were you
> expecting icomplete-vertical to add verticality to fido-mode?

Since fido-mode is just icomplete-mode with nice defaults, icomplete-vertical just becomes fido-vertical. With that patch they took, it works like a charm. I get all the semantics and keybindings of fido-mode, and use the icomplete-vertical-do macro for my yank-pop+ and recentf-list+ functions based on completing-read (the content in these completions tables is better suited to a vertical representation, whereas most of the time I want the default horizontal representation).

> The only thing that might be worth investigating is why
> icomplete-vertical needs to call icomplete-mode when it's
> already enabled.  Maybe we could arrange for this not to be needed at
> all and avoid the problem.

I patched icomplete-vertical with (unless icomplete-mode (icomplete-mode)), but it felt like a work-around. I don’t know of any other instance where calling foo-mode non-interactively will break things if it’s already enabled. I thought they were usually idempotent.

Cheers,

Andy

[-- Attachment #2: Type: text/html, Size: 4234 bytes --]

      parent reply	other threads:[~2020-06-06  5:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 17:49 Should (icomplete-mode) explicitly disable fido-mode? Andrew Schwartzmeyer
2020-06-05 22:48 ` João Távora
2020-06-05 23:19   ` Stefan Monnier
2020-06-06  5:14   ` Andrew Schwartzmeyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F21BA4E-0725-46D5-80D2-CBB96ADBF45A@schwartzmeyer.com \
    --to=andrew@schwartzmeyer.com \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).