From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Should (icomplete-mode) explicitly disable fido-mode? Date: Fri, 05 Jun 2020 23:48:38 +0100 Message-ID: <87o8pxjfi1.fsf@gmail.com> References: <7ADEE954-6074-4C8E-9EB7-7BF93F6F46BD@schwartzmeyer.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Andrew Schwartzmeyer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 06 00:49:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhL9S-0003mI-BB for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 00:49:26 +0200 Original-Received: from localhost ([::1]:49234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhL9R-0005vr-7E for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 18:49:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhL8w-0005Vj-82 for emacs-devel@gnu.org; Fri, 05 Jun 2020 18:48:54 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:38092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhL8v-0006tM-C9 for emacs-devel@gnu.org; Fri, 05 Jun 2020 18:48:53 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id e1so11261319wrt.5 for ; Fri, 05 Jun 2020 15:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=zhMuxHfs06ApvRaYkskITNBjafRvDsxYg6G27JnLbKY=; b=LfP6T0MHSes23DzmZ3sJmEx/XiUfTvh4OQ+Qi7ud9DPEzWD+pB68gfs6b0kmwqdhbU YBBIl/2kt/dVzk1+2LaFAHhBzvAU2gHyPTMTY/L0wz+g2G7cd+YsAwV5+Kx4JEX0HTdd MBtj3wjygXpHtL7ng7h0QaeP+SAaEfmw5PeiIVFOeR1CcH75PFhwKl0W331D4mzRqJhx kdddy+XItBWN2g+e05ntnGlrrWCdIolI+p+wIoSOLJ8LWWhlia85XnKJe6v6tjFJ2hEn GYLO23B07U/3d6/gpmMynnhdeXpHoFWA7R5VCfDLrOOiQWymLkPpctd9InHpTw5VYSRA B9tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=zhMuxHfs06ApvRaYkskITNBjafRvDsxYg6G27JnLbKY=; b=WMa3d5xJkLg2gtLuEhH8cnpCubHsEKUK0+nJT8yLs1QLIt17sPb5MH98z3BulCnGxy IsOu3DIwoNV5KLkz6FkLREKbzVHlZnO3Ycs4Su2jpzww1l1IVELIFvm3pf8V7HoY5njL V5jfYUJV0r4vcMPZyfeqnB5Jehz92H1t3zmmhqE/P5tQ4L5kR1MExq1CCqiDosH76HsL 36S5xBFn1wc4bDvbvOvFLE+1UxjMxMmRL/GOw5XJTRwDCc+ruDtYHVh3GE0OGbViUGr6 60Rgo4+j2mJmUXzZagZkzgkI8rGcfd0FPCVaW6tzuTUvAYD5zqpQZojnOJiZdWRr4tQq KJNw== X-Gm-Message-State: AOAM532+hjfyH28j3pY6eTzEWuyRWOUM9zoeTRNH5rMMtgjgYWo+OvzU n8E1cnOtzGGjSy8vB0y20WI= X-Google-Smtp-Source: ABdhPJzAil8qXsxoHkWxNObHFI05tB0bOge9U1wtvDGJaJelz2f95rq6AWovM0GlIuqIKEpZogsssw== X-Received: by 2002:adf:f4c6:: with SMTP id h6mr12119247wrp.398.1591397330913; Fri, 05 Jun 2020 15:48:50 -0700 (PDT) Original-Received: from krug ([89.180.147.39]) by smtp.gmail.com with ESMTPSA id d16sm13124796wmd.42.2020.06.05.15.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 15:48:50 -0700 (PDT) In-Reply-To: <7ADEE954-6074-4C8E-9EB7-7BF93F6F46BD@schwartzmeyer.com> (Andrew Schwartzmeyer's message of "Thu, 4 Jun 2020 10:49:05 -0700") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x429.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251919 Archived-At: Andrew Schwartzmeyer writes: > icomplete-vertical calls (icomplete-mode), I think expecting it to be > idempotent (not have any effect if icomplete-mode is already enabled), > but in fact, since fido-mode is currently enabled this explicitly > disables it and switches to the base icomplete-mode, as the mode > functions icomplete-mode and fido-mode act like toggles of each > other. But isn't the end result what icomplete-vertical is after? i.e. icomplete with some kind of verticality added? Or were you expecting icomplete-vertical to add verticality to fido-mode? > Should (icomplete-mode t) perhaps do nothing if fido-mode is already > enabled? Maybe. > I=E2=80=99m not sure. Obviously the package can workaround it (given > my patch), but I think it=E2=80=99s unexpected to have to avoid calling > (icomplete-mode) if the icomplete-mode var is already t. What do you > think? It's a tricky situation, indeed. Fido-mode sets the icomplete-mode variable for effects, i.e. to have some functions that check that variable behave differently. But tries not to "be" icomplete-mode. Maybe Stefan Monnier would have something to say about this Jo=C3=A3o