unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Phil Sainty <psainty@orcon.net.nz>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: Round-tripping key definitions
Date: Mon, 15 Nov 2021 09:21:01 +0100	[thread overview]
Message-ID: <87o86lzv6a.fsf@gnus.org> (raw)
In-Reply-To: <87y25pzxgw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 15 Nov 2021 08:31:27 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> D'oh.  That's the global key binding.  Let's see...  With:

The following seems to do the trick (in both GUI and TUI Emacs).

(Not meant as a patch, but to illustrate -- we should instead not bind
the stuff that this unbinds.)

So if we do the same with RET and DEL, we should basically be OK?

diff --git a/lisp/indent.el b/lisp/indent.el
index aa6b8d17c4..e8426ae854 100644
--- a/lisp/indent.el
+++ b/lisp/indent.el
@@ -805,7 +805,11 @@ move-to-tab-stop
                 (forward-char -1))
               (delete-region (point) before)))))))
 
-(define-key global-map "\t" 'indent-for-tab-command)
+(define-key global-map [TAB] 'indent-for-tab-command)
+(define-key global-map [?\C-i] nil)
+(define-key global-map [tab] nil)
+(define-key function-key-map [?\C-i] [TAB])
+(define-key function-key-map [tab] [TAB])
 (define-key esc-map "\C-\\" 'indent-region)
 (define-key ctl-x-map "\t" 'indent-rigidly)
 (define-key esc-map "i" 'tab-to-tab-stop)
diff --git a/src/keymap.c b/src/keymap.c
index 29d2ca7ab7..6034b1e569 100644
--- a/src/keymap.c
+++ b/src/keymap.c
@@ -1129,8 +1129,10 @@ DEFUN ("define-key", Fdefine_key, Sdefine_key, 3, 3, 0,
 	    CHECK_CHARACTER_CDR (c);
 	}
 
+	  /*
       if (SYMBOLP (c))
 	silly_event_symbol_error (c);
+	  */
 
       if (FIXNUMP (c)
 	  && (XFIXNUM (c) & meta_bit)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-11-15  8:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13  4:58 Round-tripping key definitions Lars Ingebrigtsen
2021-11-13 14:43 ` Stefan Monnier
2021-11-13 14:50   ` Lars Ingebrigtsen
2021-11-13 15:23     ` Stefan Monnier
2021-11-14  0:33       ` Phil Sainty
2021-11-14 14:27         ` Stefan Monnier
2021-11-14 15:07           ` Andreas Schwab
2021-11-14 17:56             ` Stefan Monnier
2021-11-14 18:03           ` Lars Ingebrigtsen
2021-11-14 18:37             ` Stefan Monnier
2021-11-14 18:51               ` Lars Ingebrigtsen
2021-11-14 22:27                 ` Stefan Monnier
2021-11-15  5:48                   ` Lars Ingebrigtsen
2021-11-15  7:31                     ` Lars Ingebrigtsen
2021-11-15  8:21                       ` Lars Ingebrigtsen [this message]
2021-11-15 21:10                         ` Stefan Monnier
2021-11-16  7:41                           ` Lars Ingebrigtsen
2021-11-17  8:01                             ` Lars Ingebrigtsen
2021-11-16  4:06           ` Richard Stallman
2021-11-17 20:38             ` Stefan Monnier
2021-11-18  2:25               ` Po Lu
2021-11-18  2:48                 ` Stefan Monnier
2021-11-18  2:58                   ` Po Lu
2021-11-18 11:16                   ` Stefan Kangas
2021-11-18 12:31                     ` Po Lu
2021-11-19  4:44                 ` Richard Stallman
2021-11-18  9:08               ` Lars Ingebrigtsen
2021-11-14  0:39       ` Lars Ingebrigtsen
2021-11-14 14:09         ` Stefan Monnier
2021-11-15  4:53   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o86lzv6a.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).