unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com,  emacs-devel@gnu.org
Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS
Date: Sun, 28 Nov 2021 10:54:26 +0800	[thread overview]
Message-ID: <87o8657zx9.fsf@yahoo.com> (raw)
In-Reply-To: <87tufzdrez.fsf@yahoo.com> (Po Lu's message of "Fri, 26 Nov 2021 20:37:08 +0800")

Po Lu <luangruo@yahoo.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> It's simple: we could provide a variable to scale the pixels
>> calculated by the *term code.
>
> Alternatively, how about putting such an option in the code that makes
> use of such events, something like `pixel-scroll-precision-scale'.

diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el
index 888320cf1a..a14c211207 100644
--- a/lisp/pixel-scroll.el
+++ b/lisp/pixel-scroll.el
@@ -100,6 +100,11 @@ pixel-scroll-precision-mode-map
     map)
   "The key map used by `pixel-scroll-precision-mode'.")
 
+(defcustom pixel-scroll-precision-scale 1.0
+  "Value by which to multiply pixel deltas used in `pixel-scroll-precision-mode'."
+  :type 'float
+  :group 'mouse)
+
 (defun pixel-scroll-in-rush-p ()
   "Return non-nil if next scroll should be non-smooth.
 When scrolling request is delivered soon after the previous one,
@@ -476,7 +481,8 @@ pixel-scroll-precision
   (let ((window (mwheel-event-window event)))
     (if (and (nth 4 event)
              (zerop (window-hscroll window)))
-        (let ((delta (round (cdr (nth 4 event)))))
+        (let ((delta (round (* pixel-scroll-precision-scale
+                               (cdr (nth 4 event))))))
           (if (> (abs delta) (window-text-height window t))
               (mwheel-scroll event nil)
             (with-selected-window window
-- 
2.33.1

WDYT about this?  Thanks.



  parent reply	other threads:[~2021-11-28  2:54 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211125030922.2353.1129@vcs0.savannah.gnu.org>
     [not found] ` <20211125030924.7258E2094B@vcs0.savannah.gnu.org>
2021-11-25 10:26   ` master e37eb7f: Add support for pixel wheel deltas on NS Robert Pluim
2021-11-25 10:34     ` Po Lu
2021-11-25 10:47       ` Robert Pluim
2021-11-25 11:02       ` Eli Zaretskii
2021-11-26  0:39         ` Po Lu
2021-11-26  6:35           ` Eli Zaretskii
2021-11-26  7:00             ` Po Lu
2021-11-26  8:17               ` Eli Zaretskii
2021-11-26  9:37                 ` Po Lu
2021-11-26 11:32                   ` Eli Zaretskii
2021-11-26 11:44                     ` Po Lu
2021-11-26 16:55                       ` Eli Zaretskii
2021-11-27  0:02                         ` Po Lu
2021-11-27  6:09                           ` Eli Zaretskii
2021-11-27  6:41                             ` Po Lu
2021-11-27  7:05                               ` Eli Zaretskii
2021-11-27  7:14                                 ` Po Lu
2021-11-27 10:47                                   ` Eli Zaretskii
2021-11-27 10:54                                     ` Po Lu
2021-11-27 11:03                                       ` Eli Zaretskii
2021-11-27 11:05                                         ` Po Lu
2021-11-27 11:13                                           ` Po Lu
2021-11-27 11:32                                             ` Eli Zaretskii
2021-11-27 11:34                                               ` Po Lu
2021-11-27 11:40                                                 ` Eli Zaretskii
2021-11-27 11:44                                                   ` Po Lu
2021-11-27 12:02                                                     ` Eli Zaretskii
2021-11-27 12:11                                                       ` Po Lu
2021-11-27 12:36                                                         ` Eli Zaretskii
2021-11-27 12:48                                                           ` Po Lu
2021-11-26 11:48                     ` Eli Zaretskii
2021-11-26 12:05                       ` Po Lu
2021-11-26 12:23                         ` Eli Zaretskii
2021-11-26 12:37                           ` Po Lu
2021-11-26 19:39                             ` Alan Third
2021-11-26 19:45                               ` Eli Zaretskii
2021-11-26 19:54                                 ` Alan Third
2021-11-28  2:54                             ` Po Lu [this message]
2021-11-28  7:53                               ` Eli Zaretskii
2021-11-28  7:58                                 ` Po Lu
2021-11-28  8:28                                   ` Eli Zaretskii
2021-11-29  7:39                                     ` Po Lu
2021-11-29 12:50                                       ` Eli Zaretskii
2021-11-29 13:19                                         ` Po Lu
2021-11-25 11:00     ` Eli Zaretskii
2021-11-25 18:46       ` Stefan Monnier
2021-11-25 18:58         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8657zx9.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).