unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS
Date: Thu, 25 Nov 2021 11:47:00 +0100	[thread overview]
Message-ID: <87wnkwfr6j.fsf@gmail.com> (raw)
In-Reply-To: <87fsrkzfq1.fsf@yahoo.com> (Po Lu's message of "Thu, 25 Nov 2021 18:34:14 +0800")

>>>>> On Thu, 25 Nov 2021 18:34:14 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> Robert Pluim <rpluim@gmail.com> writes:
    Po> Add support for pixel wheel deltas on NS
    >> 
    Po> * src/xterm.c (x_coalesce_scroll_events): Update doc string.
    Po> * src/nsterm.c (- mouseDown): Report pixel scroll deltas.

    >> nsterm.m, not .c. I guess you didnʼt use C-x 4 a to write the log
    >> message.

    Po> That's right.  Good catch, sorry, but I couldn't get
    Po> add-change-log-entry to fill entries satisfactorily for use with Git.

add-change-log-entry doesnʼt need to fill the entry. You can refill in
the *vc-log* buffer when committing. Or recentish versions of magit
have a 'magit-generate-changelog' command. (please donʼt tell me
youʼre not using Emacs to commit changes :-) )

    Po> +
    Po> +  DEFVAR_BOOL ("x-coalesce-scroll-events", x_coalesce_scroll_events,
    Po> +	       doc: /* SKIP: real doc in xterm.c.  */);
    Po> +  x_coalesce_scroll_events = true;
    Po> +

    >> We now have 3 definitions of x-coalesce-scroll-events. Is there not
    >> somewhere more generic where you can put it? (and I suspect we can
    >> drop the x- bit).

    Po> Not until MS-Windows gains this support, I think.

Iʼm sure we have similar variables already, but none spring to mind
:-)

Robert
-- 



  reply	other threads:[~2021-11-25 10:47 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211125030922.2353.1129@vcs0.savannah.gnu.org>
     [not found] ` <20211125030924.7258E2094B@vcs0.savannah.gnu.org>
2021-11-25 10:26   ` master e37eb7f: Add support for pixel wheel deltas on NS Robert Pluim
2021-11-25 10:34     ` Po Lu
2021-11-25 10:47       ` Robert Pluim [this message]
2021-11-25 11:02       ` Eli Zaretskii
2021-11-26  0:39         ` Po Lu
2021-11-26  6:35           ` Eli Zaretskii
2021-11-26  7:00             ` Po Lu
2021-11-26  8:17               ` Eli Zaretskii
2021-11-26  9:37                 ` Po Lu
2021-11-26 11:32                   ` Eli Zaretskii
2021-11-26 11:44                     ` Po Lu
2021-11-26 16:55                       ` Eli Zaretskii
2021-11-27  0:02                         ` Po Lu
2021-11-27  6:09                           ` Eli Zaretskii
2021-11-27  6:41                             ` Po Lu
2021-11-27  7:05                               ` Eli Zaretskii
2021-11-27  7:14                                 ` Po Lu
2021-11-27 10:47                                   ` Eli Zaretskii
2021-11-27 10:54                                     ` Po Lu
2021-11-27 11:03                                       ` Eli Zaretskii
2021-11-27 11:05                                         ` Po Lu
2021-11-27 11:13                                           ` Po Lu
2021-11-27 11:32                                             ` Eli Zaretskii
2021-11-27 11:34                                               ` Po Lu
2021-11-27 11:40                                                 ` Eli Zaretskii
2021-11-27 11:44                                                   ` Po Lu
2021-11-27 12:02                                                     ` Eli Zaretskii
2021-11-27 12:11                                                       ` Po Lu
2021-11-27 12:36                                                         ` Eli Zaretskii
2021-11-27 12:48                                                           ` Po Lu
2021-11-26 11:48                     ` Eli Zaretskii
2021-11-26 12:05                       ` Po Lu
2021-11-26 12:23                         ` Eli Zaretskii
2021-11-26 12:37                           ` Po Lu
2021-11-26 19:39                             ` Alan Third
2021-11-26 19:45                               ` Eli Zaretskii
2021-11-26 19:54                                 ` Alan Third
2021-11-28  2:54                             ` Po Lu
2021-11-28  7:53                               ` Eli Zaretskii
2021-11-28  7:58                                 ` Po Lu
2021-11-28  8:28                                   ` Eli Zaretskii
2021-11-29  7:39                                     ` Po Lu
2021-11-29 12:50                                       ` Eli Zaretskii
2021-11-29 13:19                                         ` Po Lu
2021-11-25 11:00     ` Eli Zaretskii
2021-11-25 18:46       ` Stefan Monnier
2021-11-25 18:58         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnkwfr6j.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).