From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS Date: Sun, 28 Nov 2021 10:54:26 +0800 Message-ID: <87o8657zx9.fsf@yahoo.com> References: <20211125030922.2353.1129@vcs0.savannah.gnu.org> <20211125030924.7258E2094B@vcs0.savannah.gnu.org> <871r34h6pi.fsf@gmail.com> <87fsrkzfq1.fsf@yahoo.com> <83tug05whz.fsf@gnu.org> <87tufzycli.fsf@yahoo.com> <837dcv4e79.fsf@gnu.org> <87wnkvflk7.fsf@yahoo.com> <83zgpr2uvr.fsf@gnu.org> <87fsrjfeb1.fsf@yahoo.com> <83r1b32lvr.fsf@gnu.org> <83pmqn2l3s.fsf@gnu.org> <8735njf7gz.fsf@yahoo.com> <83mtlr2jhw.fsf@gnu.org> <87tufzdrez.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6846"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 03:55:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrALp-0001Yk-IH for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 03:55:37 +0100 Original-Received: from localhost ([::1]:46538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrALo-0000Gj-9A for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 21:55:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrAKt-0007ih-I7 for emacs-devel@gnu.org; Sat, 27 Nov 2021 21:54:39 -0500 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:40958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrAKr-0006c1-It for emacs-devel@gnu.org; Sat, 27 Nov 2021 21:54:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1638068076; bh=Lb/BM1fd2CqU1Ogz3bMUqQOwTLwg4n6/llZY2D0f9Xc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=AGhHzGLRNAB0WysDB6VBF53H0WlH/q5tU7HNdzxtbi5iBqCMrC442qDCS5wcLsbaYyQzOr/rHz7MLnWnp2/07NFNUJTi34C76bpHJNhZiQfm0CzhX/1IxYdXKnO115P7O/jhoYM/R+HaUPA0RJEkZtvSiwJsW2tv2pcGofZcXpWnXf9cq+NrIpjXRu5h3Twlq5ZORXi4OLJx3Lq39z4x2N77wdIA0275eSsnzE5guEm84FZLPsZXl0JX9AEXeVec+GcioAdR4Z67TOSSEdHRVWAvlzcExANw2hofcUFLmhwA7xzThJO3Rv3G817ypgzwWN0cnVkI/YK1cKUiBP3H3w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1638068076; bh=KtXrupeoBPR7Bbowq5M6O5p5FAjONTT9jWgG6bGWtfU=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RF6T9hhcvheWLcbrel/K2JP1f1+/hxxXxlyaouHv5JhvhOiOY7mQTeRgXa2zzZNGrGkLy+gQ+wO1AoS18yREfhve+BHT1A4iwRwetxJh/52djQj/JRGFBR7BWYE4UjW00iOi/kF6Azd44Hjai88hCVw6pVoE1KmbEg9vhYd+/KXTgPeJL8ImTj9oGsy1UzFj/LmtsgT1a8A/gpSwvifMMrQtNOFUfETpv3YvNXrqUdFiNT2DD9r3Ki96LvHBC8UNVthQ0PVioC+zT+KUKq8IimhNbgG+QljvTv4a4RyhROosS58V+AHXToGvWxI8jBymGO1i5ArdOY75m9/BPR3eWA== X-YMail-OSG: Pa4LNvMVM1k1ORSMpacUaoHjnMfMRAXl.o20EWSBG7LIDDAemsrVOhzXcqfONCd uuhYqo.zKxegwEXXjuoh3BSP.WlAq75fZ618tUTUNShc9OYncdiAurOWbGbJkp7fLQEGxfcFvuoa fjyl3JTs8_E6CBjnzaSGvbLtuHNq2HaOoDdAr6IpvLguL1Yayw_LUyegh6FOPmOC8m5rB0owy7TO _bhVcDNJj5pjKId_mU.p8fVYobWVi39BMUuz5kDo87glDbqPdOxgQ.qpIkKtJvLl3904Ktk6eHbs 4GctWWJ4FLFQSR2KnWHPZP3uj._.3W_uA2IOShNg.yYMS.AzNq4O0xcJaJRrTt8GppiQQjyjAPF4 jZjAzFUYrCF9w5M5jcPrOJalXWzz7HgI5OCMg.Jl.llnjcbZ9FNSr3DjpofeEVxByrcrOB9vwppa UNmV8eifz80QbamAYxZG8rd4dCBlNwCXj8YWenfx4tvvZDHrPHZQPGU20xv6QB3X.tgWhZy68qJM AmaxQZgj5hBbuLcomXKg2n0CpiUbngo1kHwhhpes1np4U94FB5SZC0RD1re7eseYXcAcLdf9XJs0 0s7fUqeIADdRrxRvColL3NPUwew0cyYg8Q4m_FN9GEuaDcm4Z5Nt.Rc8nNT.lR_pNTAuQV4vMdZg UGgtatk0cv_qZe.KHzp83UrOaXQkW5ArMytcz54WY6AsZM6z120rBcZZoHkMsgi1dRGSt70ZZGwh eJvf4Q7hHTwQ6FmSDksBsRgXQknsTmvlYM2nyzDOEYtTITI3NioLjxgV25fgCz_dyLv.nJUIiJMn iEMaAprxJQ9NMY1ZGLAJMgCyxQ1nPXs25Cvvjd1cLq X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sun, 28 Nov 2021 02:54:36 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0e008637b455b9511ba8316b78087735; Sun, 28 Nov 2021 02:54:31 +0000 (UTC) In-Reply-To: <87tufzdrez.fsf@yahoo.com> (Po Lu's message of "Fri, 26 Nov 2021 20:37:08 +0800") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.33; envelope-from=luangruo@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280363 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >> It's simple: we could provide a variable to scale the pixels >> calculated by the *term code. > > Alternatively, how about putting such an option in the code that makes > use of such events, something like `pixel-scroll-precision-scale'. diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el index 888320cf1a..a14c211207 100644 --- a/lisp/pixel-scroll.el +++ b/lisp/pixel-scroll.el @@ -100,6 +100,11 @@ pixel-scroll-precision-mode-map map) "The key map used by `pixel-scroll-precision-mode'.") +(defcustom pixel-scroll-precision-scale 1.0 + "Value by which to multiply pixel deltas used in `pixel-scroll-precision-mode'." + :type 'float + :group 'mouse) + (defun pixel-scroll-in-rush-p () "Return non-nil if next scroll should be non-smooth. When scrolling request is delivered soon after the previous one, @@ -476,7 +481,8 @@ pixel-scroll-precision (let ((window (mwheel-event-window event))) (if (and (nth 4 event) (zerop (window-hscroll window))) - (let ((delta (round (cdr (nth 4 event))))) + (let ((delta (round (* pixel-scroll-precision-scale + (cdr (nth 4 event)))))) (if (> (abs delta) (window-text-height window t)) (mwheel-scroll event nil) (with-selected-window window -- 2.33.1 WDYT about this? Thanks.