From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Nick Roberts <nickrob@snap.net.nz>,
mange@freemail.hu, emacs-devel@gnu.org
Subject: Re: /lib/cpp not found in c-mode
Date: Sun, 08 May 2005 13:31:20 -0400 [thread overview]
Message-ID: <87ll6pk4o0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <01c55238$Blat.v2.4$0e1c2960@zahav.net.il> (Eli Zaretskii's message of "Fri, 06 May 2005 15:34:13 +0300")
> Done. I preferred to use locate-file instead of executable-find,
> since the latter would load another package.
Actually, looking at the definition of executable-find, I'm surprised it
doesn't use locate-file. The patch below should fix it so that
executable-find uses the same code used by `call-process'.
The new code is nothing else than a call to locate-file and I'd argue
that Eli's change from executable-find to locate-file is a bad idea and
instead we should simply move executable-find from executable.el to
subr.el.
Stefan
--- orig/lisp/progmodes/executable.el
+++ mod/lisp/progmodes/executable.el
@@ -165,25 +165,7 @@
(defun executable-find (command)
"Search for COMMAND in `exec-path' and return the absolute file name.
Return nil if COMMAND is not found anywhere in `exec-path'."
- (let ((list exec-path)
- file)
- (while list
- (setq list
- (if (and (setq file (expand-file-name command (car list)))
- (let ((suffixes exec-suffixes)
- candidate)
- (while suffixes
- (setq candidate (concat file (car suffixes)))
- (if (and (file-executable-p candidate)
- (not (file-directory-p candidate)))
- (setq suffixes nil)
- (setq suffixes (cdr suffixes))
- (setq candidate nil)))
- (setq file candidate)))
- nil
- (setq file nil)
- (cdr list))))
- file))
+ (locate-file command exec-path exec-suffixes 1))
(defun executable-chmod ()
"This gets called after saving a file to assure that it be executable.
next prev parent reply other threads:[~2005-05-08 17:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 16:47 /lib/cpp not found in c-mode Stefan Monnier
2005-05-01 20:23 ` Eli Zaretskii
2005-05-02 1:29 ` Nick Roberts
2005-05-02 15:44 ` Stefan Monnier
2005-05-02 21:30 ` Nick Roberts
2005-05-04 9:46 ` Nick Roberts
2005-05-01 23:40 ` Nick Roberts
2005-05-02 4:14 ` Jan D.
2005-05-02 6:46 ` Nick Roberts
2005-05-02 19:58 ` Jan D.
2005-05-02 21:15 ` Nick Roberts
2005-05-02 22:16 ` Stefan Monnier
2005-05-03 4:05 ` Nick Roberts
2005-05-03 15:45 ` Stefan Monnier
2005-05-03 21:36 ` Nick Roberts
2005-05-03 17:12 ` Richard Stallman
2005-05-03 18:18 ` Stefan Monnier
[not found] ` <20050503233249.1C2799F4ED@mirror.positive-internet.com>
2005-05-03 23:45 ` Stefan Monnier
2005-05-04 22:05 ` Richard Stallman
2005-05-04 19:04 ` Josh Varner
2005-05-03 19:13 ` Eli Zaretskii
2005-05-03 20:23 ` Stefan Monnier
2005-05-04 20:58 ` Eli Zaretskii
2005-05-05 10:58 ` Nick Roberts
2005-05-05 17:43 ` Eli Zaretskii
[not found] ` <0FA9201A-8390-4924-BDE3-2857B0A33576@swipnet.se>
2005-05-05 21:54 ` Nick Roberts
2005-05-06 4:51 ` Jan D.
2005-05-06 7:43 ` Eli Zaretskii
2005-05-03 4:14 ` Jan D.
2005-05-03 19:49 ` Magnus Henoch
2005-05-04 20:49 ` Nick Roberts
2005-05-05 14:17 ` Stefan Monnier
2005-05-05 17:50 ` Eli Zaretskii
2005-05-05 18:19 ` Stefan Monnier
2005-05-05 21:02 ` Nick Roberts
2005-05-06 12:34 ` Eli Zaretskii
2005-05-08 2:54 ` Nick Roberts
2005-05-08 4:28 ` Eli Zaretskii
2005-05-08 4:59 ` Nick Roberts
2005-05-08 16:12 ` Richard Stallman
2005-05-08 18:43 ` Eli Zaretskii
2005-05-08 16:12 ` Richard Stallman
2005-05-08 17:31 ` Stefan Monnier [this message]
2005-05-08 19:02 ` Eli Zaretskii
2005-05-08 19:41 ` Eli Zaretskii
2005-05-08 21:18 ` Stefan Monnier
2005-05-06 12:49 ` Eli Zaretskii
2005-05-06 22:41 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ll6pk4o0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mange@freemail.hu \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).