Re: scratch/comp-static-data 82226254c86: Use ephemeral and staticvec vectors to refer to allocated objects.

Re: scratch/comp-static-data 82226254c86: Use ephemeral and staticvec vectors to refer to allocated objects.

[Po Lu]

Vibhav Pant <vibhavp@gmail.com> writes:

> +static void
> +alloc_class_check (Lisp_Object alloc_class)
> +{
> +  bool valid = EQ (alloc_class, Qd_default) ||
> +    EQ (alloc_class, Qd_impure) ||
> +    EQ (alloc_class, Qd_ephemeral);
> +  if (!valid)
> +    {
> +      xsignal2 (Qnative_ice,
> +		build_string ("invalid lisp data allocation class"),
> +		alloc_class);
> +      assume (false);
> +    }
> +}

You wrote this wrong again; it should be:

  bool valid = (EQ (alloc_class, Qd_default)
  		|| EQ (alloc_class, Qd_impure)
                || EQ (alloc_class, Qd_epemeral))

the `eassume (false)' is redundant, as xsignal2 is noreturn.  And
perhaps it would be better to move valid into the if condition entirely.

Thanks.