From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: scratch/comp-static-data 82226254c86: Use ephemeral and staticvec vectors to refer to allocated objects. Date: Thu, 09 Mar 2023 09:26:13 +0800 Message-ID: <87lek6lnpm.fsf@yahoo.com> References: <167828202998.20769.14455677610021114493@vcs2.savannah.gnu.org> <20230308132710.49F02C13A84@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 09 02:27:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa53c-0006iM-25 for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Mar 2023 02:27:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pa537-0000t6-7A; Wed, 08 Mar 2023 20:26:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pa535-0000si-Dq for emacs-devel@gnu.org; Wed, 08 Mar 2023 20:26:27 -0500 Original-Received: from sonic313-15.consmr.mail.bf2.yahoo.com ([74.6.133.125]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pa534-00038d-1R for emacs-devel@gnu.org; Wed, 08 Mar 2023 20:26:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678325184; bh=kYPRDEoZwGcQsnDaTD6tWZsyNPjmCzecSUXtt6hQinQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=d2K6ORraLOXXUL1WrIj7fUFHj/89akeQxHxfOq/QB9xpXpJUsL/qE55vxv1qN4ksJeA62M417fSIO89dY5+sTVnhM/9I9Asf33Mx5+AXF5Qux56Qzqkycs8LpSUHr/35/HvotMWHO7x0yJrswunfXJavgKSXObGad/957SIjTmwlUaOATq5HzIvwCvYgfG6jAVN1Ef5Ob4oCCn/pfAr8rTiP+cCSwxrdGTCcr5vYIPCjflm+RhwrLOxAvJjTsoL+P7EvBjpM3SunbmoqP0Pn0TsfnqpXfAZcrl83HzBBee2TVqQxV/MpbaiaMYZ7h30MZmkzaAGpJv0XoxMbKgkh9g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678325184; bh=8/Damp9leptk7DW8lKFGiONN3ib/01SB5HRAU2SkDYW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jUPyqgwDenpkZtyNVIudjWQ4y05m2P+r7f4BjekWMum+Fhpjb5FC+JwwnrzTUmtsBXT6Q4dXTKc716bP+Oi2mlTcjMYxHrmS21/JAlZ68ND3VrV1V6xl8Ml0IXABseMx0JHuQh0hBQNLFzGTkkBXPDl7c62y2LmYOPNWbgC5dktZu5gz+8iezqL9kQTgPvj/LuQQq66dhW7xaFEEHQWOq3WGR0KmGm2Vp7JTqVHaD2cAYnaovfTIsQ/WHD7Y5TOWWwi36FyYdpaHOUtdZQTrvMdJ9isgnK/gOVfAUCuDT0csYmrUnjd1+429ehq9geI5c9/1BYAt+qwN6dgYaZ4cNw== X-YMail-OSG: _OiucTwVM1ntmmsC1HxSRxe991JkRdbr5l7VOdN7RO7Gn9zSEG1hhAeOVaxNS_N qYK3lm0gm7NCRvATIGDGYd1.sMUPYPQh0Nbce18nD42CF4oYN2GG8RAaQGQHKO_gY4FcT3BXP5PI 7pBtO8XqAPJuhvysitgc6KhWIQmi7PRZHxjtXP1bEezgxv1wrTO7OVtnUGmUQPpIN1mrgILvVhx4 hnmhh7ng04u_XP0izSM6hzkTWqoi.ntZuCfPY8mGjjj5J_gXwJXwCwXpqr9rZ6LHyQmVAky66aU3 GqeFr9079pSSMwPk43lXH6p1DYOrRv8NMrvrlrcRGoOLqQlbVmVrJOQMm9mbIQ0F129I_vnCDCsY Z4ElgEd3NVv2zk4qVYmjOXhmWy.IZ0dfzocXULfFxZvx0nPnaq.pS4N2HQ_VL80aT9lovSQpCPft 3suhgggORcWfVNnPqoHJmBvBIr8.7FuXz04.rY6ofa5JWkjaoZ.iOywQDsDZLAVZTOGtyFzaRm0m eoaJnZszLmBX0SoyYWJyvMQQGsw5HYBv7dsNK7L.ibMYr8heAMY6UigrpZ4P2qRsqjE6urmTHrs7 ZbSL.Duooyuh2niGK71Igmh0X_mWxNPVZp59.THcH8guePXP6RhPj2dMmK1d8oiptD3evI7UtufP xdZYWwTZGylc3fV37E0xgtNz8.zKb8fkw51lAl_9Rc217CrZw7Y2AlyLLQSll2tpL_FAwoPTffob dScxU6VL1xFfl4Wj.X.A0VoPe.kfx89mvLtoSgiXllPotmtS9yeGy539yiFFHEoCbVXIK5nZgRHX kQzAq3M37xoHzsUqcINRkb0a7ACe5pCLhyAhNW.Pd7 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.bf2.yahoo.com with HTTP; Thu, 9 Mar 2023 01:26:24 +0000 Original-Received: by hermes--production-sg3-67c57bccff-wt27l (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b8dfce489cc5587834e037d904d6595c; Thu, 09 Mar 2023 01:26:18 +0000 (UTC) In-Reply-To: <20230308132710.49F02C13A84@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Wed, 8 Mar 2023 08:27:10 -0500 (EST)") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=74.6.133.125; envelope-from=luangruo@yahoo.com; helo=sonic313-15.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304160 Archived-At: Vibhav Pant writes: > +static void > +alloc_class_check (Lisp_Object alloc_class) > +{ > + bool valid = EQ (alloc_class, Qd_default) || > + EQ (alloc_class, Qd_impure) || > + EQ (alloc_class, Qd_ephemeral); > + if (!valid) > + { > + xsignal2 (Qnative_ice, > + build_string ("invalid lisp data allocation class"), > + alloc_class); > + assume (false); > + } > +} You wrote this wrong again; it should be: bool valid = (EQ (alloc_class, Qd_default) || EQ (alloc_class, Qd_impure) || EQ (alloc_class, Qd_epemeral)) the `eassume (false)' is redundant, as xsignal2 is noreturn. And perhaps it would be better to move valid into the if condition entirely. Thanks.