From: "João Távora" <joaotavora@gmail.com>
To: Michael Eliachevitch <m.eliachevitch@posteo.de>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual
Date: Wed, 15 Mar 2023 18:54:36 +0000 [thread overview]
Message-ID: <87lejx6e1f.fsf@gmail.com> (raw)
In-Reply-To: <87o7oudv7s.fsf@posteo.de> (Michael Eliachevitch's message of "Wed, 15 Mar 2023 12:52:45 +0000")
Michael Eliachevitch <m.eliachevitch@posteo.de> writes:
> Thanks Eli, I incorporated your comments into v2 of the patch attached
> below.
Thanks Michael and Eli.
I'll push the patch soon it with a
Copyright-paperwork-exempt: Yes
cookie, since this seems to fall under the "trivial" basket, but you
should probably get a FSF copyright assignment for future contributions.
Minor comments below.
> (setq-default eglot-workspace-configuration
> @@ -1241,17 +1241,21 @@ JSONRPC objects in Elisp
> For representing the JSON leaf values @code{true}, @code{false},
> @code{null} and @code{@{@}}, you can use the Lisp values @code{t},
> @code{:json-false}, @code{nil}, and @code{eglot-@{@}}, respectively.
> +JSON arrays are represented as lisp vectors surrounded by square
> brackets
"Lisp" should be capitalized (pedantically, "Elisp", since vectors in
other dialects have different read syntax, but Lisp is fine)
> (:pylsp (:plugins (:jedi_completion (:include_params t
> - :fuzzy t)
> - :pylint (:enabled :json-false)))
> + :fuzzy t)
> + :pylint (:enabled :json-false
> + :args ["--disable" "C0103"])))
Hmmm. I don't use "pylint" but what sense does it make to disable it
entirely (supposedly, that's what :enabled :json-false does) and then
_also_ pass args to it. Should we just enable it? This is all pretend,
of course. But shouldn't it make more sense?
João
next prev parent reply other threads:[~2023-03-15 18:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 4:45 Explain a bit more on how to configure language server in Eglot's manual Yuan Fu
2023-03-05 22:36 ` [SPAM UNSURE] " Stephen Leake
2023-03-06 0:16 ` João Távora
2023-03-06 22:28 ` Yuan Fu
2023-03-07 11:59 ` João Távora
2023-03-08 13:27 ` Augusto Stoffel
2023-03-08 13:54 ` João Távora
2023-03-08 15:01 ` Augusto Stoffel
2023-03-08 19:43 ` João Távora
2023-03-08 20:43 ` Augusto Stoffel
2023-03-09 9:43 ` João Távora
2023-03-08 23:19 ` Yuan Fu
2023-03-09 8:18 ` Augusto Stoffel
2023-03-09 17:20 ` Juri Linkov
2023-03-10 6:26 ` Yuan Fu
2023-03-10 7:59 ` João Távora
2023-03-09 17:40 ` João Távora
2023-03-09 18:05 ` Juri Linkov
2023-03-09 18:32 ` Augusto Stoffel
2023-03-09 8:28 ` Explain a bit more on how to configure language server in Eglot's manual' Augusto Stoffel
2023-03-08 15:24 ` Explain a bit more on how to configure language server in Eglot's manual Yuri Khan
2023-03-08 15:27 ` João Távora
2023-03-08 15:52 ` Yuri Khan
2023-03-08 16:03 ` João Távora
2023-03-09 11:18 ` [SPAM UNSURE] " João Távora
2023-03-10 6:23 ` Yuan Fu
2023-03-14 18:09 ` Michael Eliachevitch
2023-03-14 18:53 ` João Távora
2023-03-14 22:27 ` [PATCH] " Michael Eliachevitch
2023-03-15 11:49 ` Michael Eliachevitch
2023-03-15 12:35 ` Eli Zaretskii
2023-03-15 12:52 ` Michael Eliachevitch
2023-03-15 18:54 ` João Távora [this message]
2023-03-15 19:26 ` Michael Eliachevitch
2023-03-16 0:09 ` João Távora
2023-03-06 10:34 ` Augusto Stoffel
2023-03-06 10:51 ` João Távora
2023-03-06 11:00 ` Augusto Stoffel
2023-03-06 11:13 ` João Távora
2023-03-06 11:30 ` Pedro Andres Aranda Gutierrez
2023-03-06 11:46 ` João Távora
2023-03-06 13:08 ` Augusto Stoffel
2023-03-06 13:50 ` João Távora
2023-03-06 16:10 ` Augusto Stoffel
2023-03-06 16:25 ` João Távora
2023-03-06 18:18 ` Augusto Stoffel
2023-03-06 18:32 ` João Távora
2023-03-06 20:16 ` Pedro Andres Aranda Gutierrez
2023-03-06 21:13 ` Augusto Stoffel
2023-03-06 21:38 ` João Távora
2023-03-06 13:01 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lejx6e1f.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=m.eliachevitch@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).