From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual Date: Wed, 15 Mar 2023 18:54:36 +0000 Message-ID: <87lejx6e1f.fsf@gmail.com> References: <86sfeisu49.fsf@stephe-leake.org> <87356gvkkb.fsf@gmail.com> <87wn3jgof2.fsf@posteo.de> <878rfzt0h7.fsf@posteo.de> <833566ry3v.fsf@gnu.org> <87o7oudv7s.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28711"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Eliachevitch Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 15 19:53:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcWFi-0007Ik-Ok for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Mar 2023 19:53:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcWEv-0002YP-D0; Wed, 15 Mar 2023 14:52:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcWEr-0002YD-UG for emacs-devel@gnu.org; Wed, 15 Mar 2023 14:52:43 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcWEq-00052Y-1f; Wed, 15 Mar 2023 14:52:41 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id r29so10201745wra.13; Wed, 15 Mar 2023 11:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678906357; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ugUPnZADRji185fYHq4x6aRJEwm+A6l9MW9W49CfiZY=; b=U1mfqQii14ZsBxryEWcCz6ePsKqTnjQwhxw3x/dg+mudDa2ulDbEupkhTTiRUuRe7V bGfQtFLval8mwfgRVfKc5MbS0VJYfvIZuzATc6oybTJa0VJlLYIYBRRheyMq4OQv+ubZ IfUHE72u90sxVr7ht6aVdbva3bLchEiv9E1pEr06irgK3dfbwycyCuSfR3he9FYEusej 80VKd9CAyXPv0v1cEImvILhAlKjvM19CUwn1Q2UDpxtaHB5JoeVqwkFKHXfAvYGnE6I2 I2NMC2LDr1PPZcq5S+IvBpSk5fRjZTx+anrQplWvhE5rISHkrrEYXTnT925TcMZa8rKU WIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678906357; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ugUPnZADRji185fYHq4x6aRJEwm+A6l9MW9W49CfiZY=; b=r6St4z6FEIB2m8bGyHDCb5NLn3g46YdFTByHYAR3l8tIj125Vtc0FLiS/JmUVq+esZ BV7RF6YcyTe0mC8F89vU2md6e8Pk1NZBk2E18a0JFW+dA1IF4K8epibIy3loUkJxkN1A GMT754dU54QlUfdMgwXgwBoDD68Fytz0j4K7ifYsgU1XCEbSYvjNx8ormvDVxM6iDZyj rXYLBvGPipM4l1KskFR92h1C1UdkntHTRmWRocLdLYgqmnYSNkuKWOIaVckm4DSIDpqC GiMID1KIZWjNirK+v33rySkrGjjaWU6Rb4h1/gT5H5mJm4Tivuy/26PNpPeFD3x/PQ+L jzuQ== X-Gm-Message-State: AO0yUKX/l6EXDx7NIwdXqwqLNu37TjfTqBXH9mn5HTfw2mej7DNakso4 c04wUaPf4DhS/BHQH+ZQRN5Sepkn5mU= X-Google-Smtp-Source: AK7set+2Te/yk/odzH08VeX1VWZHKMhhc+/cLe1jXOZoapqoCBLL2W9jOrjHzEm5RoIwP0u6O6YtGw== X-Received: by 2002:a5d:654b:0:b0:2cf:efd8:d502 with SMTP id z11-20020a5d654b000000b002cfefd8d502mr2633903wrv.9.1678906357364; Wed, 15 Mar 2023 11:52:37 -0700 (PDT) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id c10-20020adfed8a000000b002cf8220cc75sm5269182wro.24.2023.03.15.11.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:52:36 -0700 (PDT) In-Reply-To: <87o7oudv7s.fsf@posteo.de> (Michael Eliachevitch's message of "Wed, 15 Mar 2023 12:52:45 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304504 Archived-At: Michael Eliachevitch writes: > Thanks Eli, I incorporated your comments into v2 of the patch attached > below. Thanks Michael and Eli. I'll push the patch soon it with a Copyright-paperwork-exempt: Yes cookie, since this seems to fall under the "trivial" basket, but you should probably get a FSF copyright assignment for future contributions. Minor comments below. > (setq-default eglot-workspace-configuration > @@ -1241,17 +1241,21 @@ JSONRPC objects in Elisp > For representing the JSON leaf values @code{true}, @code{false}, > @code{null} and @code{@{@}}, you can use the Lisp values @code{t}, > @code{:json-false}, @code{nil}, and @code{eglot-@{@}}, respectively. > +JSON arrays are represented as lisp vectors surrounded by square > brackets "Lisp" should be capitalized (pedantically, "Elisp", since vectors in other dialects have different read syntax, but Lisp is fine) > (:pylsp (:plugins (:jedi_completion (:include_params t > - :fuzzy t) > - :pylint (:enabled :json-false))) > + :fuzzy t) > + :pylint (:enabled :json-false > + :args ["--disable" "C0103"]))) Hmmm. I don't use "pylint" but what sense does it make to disable it entirely (supposedly, that's what :enabled :json-false does) and then _also_ pass args to it. Should we just enable it? This is all pretend, of course. But shouldn't it make more sense? Jo=C3=A3o