From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 262d0c6: Mark some tests as expensive
Date: Mon, 19 Oct 2020 14:40:20 +0200 [thread overview]
Message-ID: <87k0vmxubv.fsf@gmx.de> (raw)
In-Reply-To: <CADwFkmn899WN4TE6NUEjBhgzixCLtzn46QwrjAJy-E1Y7x3xhA@mail.gmail.com> (Stefan Kangas's message of "Sun, 18 Oct 2020 11:15:10 -0700")
Stefan Kangas <stefan@marxist.se> writes:
> Hi Michael,
Hi Stefan,
>> Would be helpful. However, there have been discussions (and changes) of
>> the timeouts in the past, so I'm not sure we can reduce them w/o causing
>> damage. Please check the git history of autorevert-tests.el for such
>> changes, hopefully there are bug numbers in the git log you could consult
>> for the respective discussions. Otherwise, a search on the emacs-devel
>> and emacs-bugs MLs for the given timeframe of such a change might be helpful.
>
> So I have attached here a patch that employs the above mentioned
> techniques somewhat aggressively to reduce the running time as follows:
>
> Ran 7 tests, 7 results as expected, 0 unexpected (2020-10-18
> 19:38:29+0200, 2.323729 sec)
Thanks!
> Everything works fine here, but I don't know if any of this would cause
> any problems elsewhere. One idea is to just push it and see what
> breaks, and then adapt accordingly.
>
> Please let me know what you think.
Yes, let's go this way. Maybe there will be problems in the remote case,
but this we could adapt later on.
> Also, I've had some trouble finding the past discussions about this.
>
> But I'm not sure if any of that is even relevant here. Let me know if
> you have any ideas for what I could look for.
No, my history isn't organized as good as it should :-(
> * test/lisp/autorevert-tests.el (auto-revert--timeout): Make into
> defun and shorten timeout by a factor 10.
Why is it a defun now? Likely, I have overseen the reason ...
Best regards, Michael.
> Best regards,
> Stefan Kangas
next prev parent reply other threads:[~2020-10-19 12:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200910182904.20559.25935@vcs0.savannah.gnu.org>
[not found] ` <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org>
2020-09-11 9:25 ` master 262d0c6: Mark some tests as expensive Michael Albinus
2020-09-11 18:06 ` Stefan Kangas
2020-09-12 10:25 ` Daniel Martín
2020-09-12 10:38 ` Eli Zaretskii
2020-09-12 11:15 ` Lars Ingebrigtsen
2020-09-12 11:24 ` Eli Zaretskii
2020-09-12 12:11 ` Lars Ingebrigtsen
2020-09-12 12:29 ` Eli Zaretskii
2020-09-13 12:30 ` Lars Ingebrigtsen
2020-09-13 15:21 ` Stefan Monnier
2020-09-13 15:30 ` Lars Ingebrigtsen
2020-09-13 17:22 ` Michael Albinus
2020-09-12 16:47 ` Michael Albinus
2020-09-13 12:33 ` Lars Ingebrigtsen
2020-09-13 14:37 ` Eli Zaretskii
2020-09-12 11:27 ` Michael Albinus
2020-09-12 12:15 ` Lars Ingebrigtsen
2020-09-12 12:30 ` Michael Albinus
2020-09-12 12:36 ` Lars Ingebrigtsen
2020-09-12 13:04 ` Dmitry Gutov
2020-09-12 14:23 ` Daniel Martín
2020-09-12 14:49 ` Michael Albinus
2020-09-12 16:47 ` Dmitry Gutov
2020-09-12 14:53 ` Lars Ingebrigtsen
2020-09-12 14:00 ` Daniel Martín
2020-09-12 14:14 ` Eli Zaretskii
2020-09-12 15:16 ` Daniel Martín
2020-09-12 14:43 ` Michael Albinus
2020-09-12 15:02 ` Daniel Martín
2020-09-12 10:52 ` Michael Albinus
2020-09-18 10:22 ` Stefan Kangas
2020-09-18 10:31 ` Michael Albinus
2020-10-18 18:15 ` Stefan Kangas
2020-10-19 12:40 ` Michael Albinus [this message]
2020-10-19 15:34 ` Stefan Kangas
2020-10-19 16:42 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0vmxubv.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).