unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: stefan@marxist.se, emacs-devel@gnu.org, michael.albinus@gmx.de,
	mardani29@yahoo.es
Subject: Re: master 262d0c6: Mark some tests as expensive
Date: Sat, 12 Sep 2020 14:24:08 +0300	[thread overview]
Message-ID: <837dszdyqv.fsf@gnu.org> (raw)
In-Reply-To: <87a6xv456t.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat,  12 Sep 2020 13:15:06 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Daniel Martín <mardani29@yahoo.es>,
>   michael.albinus@gmx.de,
>   stefan@marxist.se,  emacs-devel@gnu.org
> Date: Sat, 12 Sep 2020 13:15:06 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I also don't understand the more general issue with how long the test
> > suite runs.  While it runs, you can do something useful on a modern
> > system (or just go for a coffee), so why does it matter?
> 
> I appreciate a fast test suite -- I often do a "make check" before
> pushing just to see that nothing was inadvertently broken by a
> seemingly-innocuous change.

How will that work if the change was in Tramp, or was related to
Tramp?  In my case, for example, it would most probably mean none of
the Tramp tests will ever run at all, because they all take more than
1 sec down here.

Also, there are some tests with inherent delays (auto-revert tests are
one example, but there are others) -- would that mean we don't run
these, either?

What I do for a "fast test" use case is to run only the tests directly
related to the change, usually the FOO-tests.el tests that correspond
to the file FOO I've changed.  Sometimes, there are related tests in
other files as well.  A simple "make FOO-tests" command is all that's
needed.

IOW, I don't think the time to run the tests is a good criterion, at
least not if applied globally to the entire suite.



  reply	other threads:[~2020-09-12 11:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200910182904.20559.25935@vcs0.savannah.gnu.org>
     [not found] ` <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org>
2020-09-11  9:25   ` master 262d0c6: Mark some tests as expensive Michael Albinus
2020-09-11 18:06     ` Stefan Kangas
2020-09-12 10:25       ` Daniel Martín
2020-09-12 10:38         ` Eli Zaretskii
2020-09-12 11:15           ` Lars Ingebrigtsen
2020-09-12 11:24             ` Eli Zaretskii [this message]
2020-09-12 12:11               ` Lars Ingebrigtsen
2020-09-12 12:29                 ` Eli Zaretskii
2020-09-13 12:30                   ` Lars Ingebrigtsen
2020-09-13 15:21                     ` Stefan Monnier
2020-09-13 15:30                       ` Lars Ingebrigtsen
2020-09-13 17:22                       ` Michael Albinus
2020-09-12 16:47                 ` Michael Albinus
2020-09-13 12:33                   ` Lars Ingebrigtsen
2020-09-13 14:37                     ` Eli Zaretskii
2020-09-12 11:27             ` Michael Albinus
2020-09-12 12:15               ` Lars Ingebrigtsen
2020-09-12 12:30                 ` Michael Albinus
2020-09-12 12:36                   ` Lars Ingebrigtsen
2020-09-12 13:04                   ` Dmitry Gutov
2020-09-12 14:23                     ` Daniel Martín
2020-09-12 14:49                     ` Michael Albinus
2020-09-12 16:47                       ` Dmitry Gutov
2020-09-12 14:53                     ` Lars Ingebrigtsen
2020-09-12 14:00           ` Daniel Martín
2020-09-12 14:14             ` Eli Zaretskii
2020-09-12 15:16               ` Daniel Martín
2020-09-12 14:43             ` Michael Albinus
2020-09-12 15:02               ` Daniel Martín
2020-09-12 10:52       ` Michael Albinus
2020-09-18 10:22         ` Stefan Kangas
2020-09-18 10:31           ` Michael Albinus
2020-10-18 18:15             ` Stefan Kangas
2020-10-19 12:40               ` Michael Albinus
2020-10-19 15:34                 ` Stefan Kangas
2020-10-19 16:42                   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837dszdyqv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=mardani29@yahoo.es \
    --cc=michael.albinus@gmx.de \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).