From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Mon, 19 Oct 2020 14:40:20 +0200 Message-ID: <87k0vmxubv.fsf@gmx.de> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <87pn6rgtcl.fsf@gmx.de> <87363f9y0f.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 19 14:45:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUUXw-0005Tm-K6 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Oct 2020 14:45:52 +0200 Original-Received: from localhost ([::1]:55192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUUXv-0005CP-9Q for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Oct 2020 08:45:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUUSk-0002ml-JA for emacs-devel@gnu.org; Mon, 19 Oct 2020 08:40:30 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:41697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUUSi-0007V2-A1 for emacs-devel@gnu.org; Mon, 19 Oct 2020 08:40:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603111224; bh=c4H0AkGF7P/0SpdTei+jLQmLQl4g2jPoYEByNykeyBs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YBW/d039gm7Bcb914tAjT1QQkqxvhCYK+m00CkeFpdhvnmFjFcfuXYMatBC2fcVeJ klJBs72xqbLDx9B/CCG1Z9fbVDNzDiwFNc1Mx7GXS3cFn956wTyzvjdmvr3UxeiYUp 2S6QeCi7JOgjTLITeCA71/3++NBD4Li4sJ6HLXBg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.242.51]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5G9t-1kKHlC2mkH-01179R; Mon, 19 Oct 2020 14:40:23 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 18 Oct 2020 11:15:10 -0700") X-Provags-ID: V03:K1:jkpeRvWrrSQIlbmBBFLxwLiYMPccxCyWA5yAc8tFM7vKBjSaYe5 ldHvpkn+RHcL9oTfTqMI9CkJwuPpJBIXjDm37fd/yX1+0fEcK58U0+Bs442HHmGCl+wyqkh 7JT2IgpHC+Bhs90/pKeR6v3cnjezJCZya6011FuYhRP1tPSmdqUojllTDbo4mnk54wXy0DH CNxpAgPhPfjS6oa/cKbEw== X-UI-Out-Filterresults: notjunk:1;V03:K0:1NK5QjNoU8I=:miUm69BlHkjPiSujrAT5Nj zTB8lOT4f06MaY8bWjSqV+VJCy+1rkc58YA8YOQ3fqbL/INEUTHdE9D1O+k1tCEzBzF5gGwqU M6ouxQgn3OOUVRyN/GfWXZZs8D3c7dsifmTV9b0MHyeJf5BSmntjSaBthdd6AOBc06kYm4zi6 mbLvFD/CYvH2JeNtjpwob5797JFT3Kh9nI/9yUTnrwYO16vRA08rducPqkmDRHo1jQbCDwBDn DemFY+g1HCAZs9hywyS1vH3YIcNof7oE9cgEP+JjWRAadsGzZL6Ef71bM+pP1xyOCBVslkZIs USwFTGM4kpWVhlyXf016JSA9MV9C8oY/cVmP02xw7Pl5CJT2dPmmX3vzTiVpybBP4PvO2JWPg Ztqvm4pk6MnWFWoR8tLAIXkaQ1aIOusGHs3MCmSoJTR+pOuSy6PRa1lFGRuSofR+hPJAULA24 hGECWQFEFIT/Z32Oyb3g4tPalqtotIu42AOxOvbbwzkugDLPpkhtf/69ePHcbLZ4cnyhKTOOs dtFrLcgNBz/blCaJAD1GRKzN1fnF1VGtSEAjoWHt2rzf7MFDAEx+8geKekPGjoxCQtStB4PkD Lxtk1lBJ9CaLkul++Jcminwyw+Af3wIHD1hMXOWQ1fXC6MGvIXkPsFZn+ka/8yZPy8WKl0nAX aav/kXrO26dlQVc/mh2N9x8tAtICBV6WTYf29D1iQZsu3lZJ+duIQdhxuBAiDTvENJp20Smge TEjpOBVHghzlc3zLbpUM9zdi8W7PwT6k6+CDHVtfHLvDNv/D3Qezlgk5t5nKCsyMNM221rc+ Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 06:51:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258109 Archived-At: Stefan Kangas writes: > Hi Michael, Hi Stefan, >> Would be helpful. However, there have been discussions (and changes) of >> the timeouts in the past, so I'm not sure we can reduce them w/o causing >> damage. Please check the git history of autorevert-tests.el for such >> changes, hopefully there are bug numbers in the git log you could consult >> for the respective discussions. Otherwise, a search on the emacs-devel >> and emacs-bugs MLs for the given timeframe of such a change might be helpful. > > So I have attached here a patch that employs the above mentioned > techniques somewhat aggressively to reduce the running time as follows: > > Ran 7 tests, 7 results as expected, 0 unexpected (2020-10-18 > 19:38:29+0200, 2.323729 sec) Thanks! > Everything works fine here, but I don't know if any of this would cause > any problems elsewhere. One idea is to just push it and see what > breaks, and then adapt accordingly. > > Please let me know what you think. Yes, let's go this way. Maybe there will be problems in the remote case, but this we could adapt later on. > Also, I've had some trouble finding the past discussions about this. > > But I'm not sure if any of that is even relevant here. Let me know if > you have any ideas for what I could look for. No, my history isn't organized as good as it should :-( > * test/lisp/autorevert-tests.el (auto-revert--timeout): Make into > defun and shorten timeout by a factor 10. Why is it a defun now? Likely, I have overseen the reason ... Best regards, Michael. > Best regards, > Stefan Kangas