Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el

Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el

[Glenn Morris]

Michael Albinus wrote:

> branch: master
> commit c8ee570a8be7afaae3ea318b9d7dbffb62a7bbd0
> Author: Michael Albinus <michael.albinus@gmx.de>
> Commit: Michael Albinus <michael.albinus@gmx.de>
>
>     Suppress undesired error messages in filenotify-tests.el
[...]
> --- a/test/lisp/filenotify-tests.el
> +++ b/test/lisp/filenotify-tests.el
> @@ -665,6 +665,9 @@ delivered."
>  (setq auto-revert-notify-exclude-dir-regexp "nothing-to-be-excluded"
>        auto-revert-remote-files t
>        auto-revert-stop-on-user-input nil)
> +;; In the remote case, `vc-refresh-state' returns undesired error
> +;; messages.  Let's suppress them.
> +(defalias 'vc-refresh-state 'ignore)


Hi - this means that loading filenotify-tests.el breaks Emacs VC normal
operation for the rest of the session, which seems undesirable. Is there
an alternative solution?

Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

>> --- a/test/lisp/filenotify-tests.el
>> +++ b/test/lisp/filenotify-tests.el
>> @@ -665,6 +665,9 @@ delivered."
>>  (setq auto-revert-notify-exclude-dir-regexp "nothing-to-be-excluded"
>>        auto-revert-remote-files t
>>        auto-revert-stop-on-user-input nil)
>> +;; In the remote case, `vc-refresh-state' returns undesired error
>> +;; messages.  Let's suppress them.
>> +(defalias 'vc-refresh-state 'ignore)
>
>
> Hi - this means that loading filenotify-tests.el breaks Emacs VC normal
> operation for the rest of the session, which seems undesirable. Is there
> an alternative solution?

I'm aware of the problem. I've tried to use `cl-letf' in the
test. Unfortunately, this doesn't work, because the revert is called
when an event arrives; the `cl-letf' settings do not work there.

Hmmm. Usually, the test is not called by average Emacs users, so I
believe it would be acceptable. If not, we must find something else.

Best regards, Michael.

Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

> I'm aware of the problem. I've tried to use `cl-letf' in the
> test. Unfortunately, this doesn't work, because the revert is called
> when an event arrives; the `cl-letf' settings do not work there.
>
> Hmmm. Usually, the test is not called by average Emacs users, so I
> believe it would be acceptable. If not, we must find something else.

I've modified my patch, using an advice. This shall not harm outside the
test.

Best regards, Michael.