* Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el [not found] ` <20170207204224.F29C22301C@vcs0.savannah.gnu.org> @ 2017-02-08 17:40 ` Glenn Morris 2017-02-08 18:00 ` Michael Albinus 0 siblings, 1 reply; 3+ messages in thread From: Glenn Morris @ 2017-02-08 17:40 UTC (permalink / raw) To: emacs-devel; +Cc: Michael Albinus Michael Albinus wrote: > branch: master > commit c8ee570a8be7afaae3ea318b9d7dbffb62a7bbd0 > Author: Michael Albinus <michael.albinus@gmx.de> > Commit: Michael Albinus <michael.albinus@gmx.de> > > Suppress undesired error messages in filenotify-tests.el [...] > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -665,6 +665,9 @@ delivered." > (setq auto-revert-notify-exclude-dir-regexp "nothing-to-be-excluded" > auto-revert-remote-files t > auto-revert-stop-on-user-input nil) > +;; In the remote case, `vc-refresh-state' returns undesired error > +;; messages. Let's suppress them. > +(defalias 'vc-refresh-state 'ignore) Hi - this means that loading filenotify-tests.el breaks Emacs VC normal operation for the rest of the session, which seems undesirable. Is there an alternative solution? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el 2017-02-08 17:40 ` master c8ee570: Suppress undesired error messages in filenotify-tests.el Glenn Morris @ 2017-02-08 18:00 ` Michael Albinus 2017-02-08 18:35 ` Michael Albinus 0 siblings, 1 reply; 3+ messages in thread From: Michael Albinus @ 2017-02-08 18:00 UTC (permalink / raw) To: Glenn Morris; +Cc: emacs-devel Glenn Morris <rgm@gnu.org> writes: >> --- a/test/lisp/filenotify-tests.el >> +++ b/test/lisp/filenotify-tests.el >> @@ -665,6 +665,9 @@ delivered." >> (setq auto-revert-notify-exclude-dir-regexp "nothing-to-be-excluded" >> auto-revert-remote-files t >> auto-revert-stop-on-user-input nil) >> +;; In the remote case, `vc-refresh-state' returns undesired error >> +;; messages. Let's suppress them. >> +(defalias 'vc-refresh-state 'ignore) > > > Hi - this means that loading filenotify-tests.el breaks Emacs VC normal > operation for the rest of the session, which seems undesirable. Is there > an alternative solution? I'm aware of the problem. I've tried to use `cl-letf' in the test. Unfortunately, this doesn't work, because the revert is called when an event arrives; the `cl-letf' settings do not work there. Hmmm. Usually, the test is not called by average Emacs users, so I believe it would be acceptable. If not, we must find something else. Best regards, Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el 2017-02-08 18:00 ` Michael Albinus @ 2017-02-08 18:35 ` Michael Albinus 0 siblings, 0 replies; 3+ messages in thread From: Michael Albinus @ 2017-02-08 18:35 UTC (permalink / raw) To: Glenn Morris; +Cc: emacs-devel Michael Albinus <michael.albinus@gmx.de> writes: > I'm aware of the problem. I've tried to use `cl-letf' in the > test. Unfortunately, this doesn't work, because the revert is called > when an event arrives; the `cl-letf' settings do not work there. > > Hmmm. Usually, the test is not called by average Emacs users, so I > believe it would be acceptable. If not, we must find something else. I've modified my patch, using an advice. This shall not harm outside the test. Best regards, Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-08 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170207204223.17232.75787@vcs0.savannah.gnu.org>
[not found] ` <20170207204224.F29C22301C@vcs0.savannah.gnu.org>
2017-02-08 17:40 ` master c8ee570: Suppress undesired error messages in filenotify-tests.el Glenn Morris
2017-02-08 18:00 ` Michael Albinus
2017-02-08 18:35 ` Michael Albinus
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).