unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/org e6e1c08: org-contacts.el: Only use org-id-store-link if org-id is loaded
       [not found] ` <20210104175710.C42DF20CB7@vcs0.savannah.gnu.org>
@ 2021-01-04 18:15   ` Stefan Monnier
  2021-01-05  3:01     ` David Florness
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2021-01-04 18:15 UTC (permalink / raw)
  To: David Florness; +Cc: emacs-devel

> -    (if org-id-link-to-org-use-id
> +    (if (and (featurep 'org-id) org-id-link-to-org-use-id)

I think the canonical way to do that is to use (boundp
'org-id-link-to-org-use-id) instead of (featurep 'org-id),
or even use (bound-and-true-p org-id-link-to-org-use-id)


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] externals/org e6e1c08: org-contacts.el: Only use org-id-store-link if org-id is loaded
  2021-01-04 18:15   ` [elpa] externals/org e6e1c08: org-contacts.el: Only use org-id-store-link if org-id is loaded Stefan Monnier
@ 2021-01-05  3:01     ` David Florness
  0 siblings, 0 replies; 2+ messages in thread
From: David Florness @ 2021-01-05  3:01 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> -    (if org-id-link-to-org-use-id
>> +    (if (and (featurep 'org-id) org-id-link-to-org-use-id)
>
> I think the canonical way to do that is to use (boundp
> 'org-id-link-to-org-use-id) instead of (featurep 'org-id),
> or even use (bound-and-true-p org-id-link-to-org-use-id)

Thank you, Stefan!  I'll send a v2.

-- 
David

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-05  3:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210104175708.10704.22581@vcs0.savannah.gnu.org>
     [not found] ` <20210104175710.C42DF20CB7@vcs0.savannah.gnu.org>
2021-01-04 18:15   ` [elpa] externals/org e6e1c08: org-contacts.el: Only use org-id-store-link if org-id is loaded Stefan Monnier
2021-01-05  3:01     ` David Florness

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).