From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Florness Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/org e6e1c08: org-contacts.el: Only use org-id-store-link if org-id is loaded Date: Mon, 04 Jan 2021 22:01:16 -0500 Message-ID: <87h7nwdr43.fsf@florness.com> References: <20210104175708.10704.22581@vcs0.savannah.gnu.org> <20210104175710.C42DF20CB7@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 05 04:22:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwcvv-0007jU-Hv for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Jan 2021 04:22:55 +0100 Original-Received: from localhost ([::1]:36148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwcvu-00021W-H1 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 22:22:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwcbF-0003pm-6b for emacs-devel@gnu.org; Mon, 04 Jan 2021 22:01:33 -0500 Original-Received: from florness.com ([50.116.27.230]:51996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwcbD-00072x-6P for emacs-devel@gnu.org; Mon, 04 Jan 2021 22:01:32 -0500 Original-Received: by florness.com (Postfix, from userid 103) id 28D406D8EE; Mon, 4 Jan 2021 20:01:24 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=florness.com; s=mail; t=1609815684; bh=KnCQ+mXgzXuviJ/jcPfamPE3PpGpPmLaVxtzhGvk05Q=; h=References:From:To:Cc:Subject:In-reply-to:Date; b=nqQfEUHiLI5YT6eVEOgRMUjdb8f35kD6bp7sjhu35RpH4T1IP4WCkRsL317sMiVvO lSn6yLHm9Dp2zGj0timFSfqMwz88tptctr9/gN4SFTpXnjgEm3gyKf4g38qg/jbTOL hH5C9YK2Vmqps95arDd57ygbErxxz00YkftT6shk= Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by florness.com (Postfix) with ESMTPSA id 20CD86D8DA; Tue, 5 Jan 2021 03:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=florness.com; s=mail; t=1609815678; bh=KnCQ+mXgzXuviJ/jcPfamPE3PpGpPmLaVxtzhGvk05Q=; h=References:From:To:Cc:Subject:In-reply-to:Date; b=JXZiiPtzmLk/ub6WeBUq1DYwq1n5O/ycDLt1tilImCI6Jy3ORanT7pn5TGMqlzdh7 lelggBqV8J+CDg3KuqqMGiTs0+iH809HjKRk8Q9dXAmjCIfoJFt0HBKEajG/sSD58q 1Cd5wJeggar732+OOW5yEE5Cryvx44qahUmK9zVo= In-reply-to: Received-SPF: pass client-ip=50.116.27.230; envelope-from=david@florness.com; helo=florness.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 04 Jan 2021 22:21:56 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262489 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >> - (if org-id-link-to-org-use-id >> + (if (and (featurep 'org-id) org-id-link-to-org-use-id) > > I think the canonical way to do that is to use (boundp > 'org-id-link-to-org-use-id) instead of (featurep 'org-id), > or even use (bound-and-true-p org-id-link-to-org-use-id) Thank you, Stefan! I'll send a v2. =2D-=20 David --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFHBAEBCAAxFiEEwHk86n9BB8P+iE+GBgV2tzUrjeMFAl/z1nwTHGRhdmlkQGZs b3JuZXNzLmNvbQAKCRAGBXa3NSuN4zhPB/9XWZl4qybYmB8mvtsdkxv4OOOn83OR 3oRI2dFilV2PHymgF/mXX9/e3bfzhBSSY6dEFwu53fa4wtYGgN3gpJdm/EEN/3Vw 8ypO9M+MrTdj96+nxjDOjIxHJca4/bM2DyDBvB/PHzaSNh5Ok3+VXy2iLMMNx7L/ eYJzAyxHIWdKykOije15XF8iqdPozLGODNGV+MG0RxvClNO+3R7DO5pe4L9AAsHu yUTd1bEKr5YYAu4GPws2V4Vw8u7o7IcxpAfqpWZZptrJUruxZJVu3rxuYuy6pYz5 FLK5barZpF74NbOXa/gNggYk6YRUpIanqlIbmX74zRrI8LH2W7mYwOWe =L94E -----END PGP SIGNATURE----- --=-=-=--