From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, emacs-devel@gnu.org, stefankangas@gmail.com,
rudiwillalwaysloveyou@gmail.com
Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target
Date: Thu, 30 Sep 2021 18:48:13 +0200 [thread overview]
Message-ID: <87h7e2vvrp.fsf@gnu.org> (raw)
In-Reply-To: <83wnmyf3u3.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Tassilo Horn <tsdh@gnu.org>
>> Date: Thu, 30 Sep 2021 16:10:02 +0200
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org,
>> rudiwillalwaysloveyou@gmail.com, Stefan Kangas <stefankangas@gmail.com>
>>
>> `dired-create-destination-dirs' already exists. But in Rudi's most
>> recent patch version, he added a new one.
>>
>> --8<---------------cut here---------------start------------->8---
>> +(defcustom dired-create-destination-dirs-trailing-separator-special nil
>
> That's a mouthful, IMO. How about
>
> dired-create-dirs-with-trailing-slash
>
> instead?
Fine with me. Rudi, could you please rework that suggestion into your
latest patch?
And please also adjust the docstring of the new option so that it
conforms to our conventions, i.e., first line is a complete sentence
(try M-x checkdoc RET), and everything is filled at column 70.
>> Rudi proposed that the default value should probably be `t' given
>> that this feels so intuitive and the only gotcha is renaming/moving
>> or copying a directory source/ to a non-existent target or target/
>> where the former has rename/make a copy semantics and the latter has
>> move/copy *into* the to be created target/ directory.
>
> Please don't make it t by default.
Ok.
> I'm quite sure you didn't consider all the use cases. E.g., what
> about foo -> Foo on case-insensitive filesystems? That is a valid use
> case where the user wants a directory renamed with a different
> letter-case.
You mean, you'd TAB-complete to the same name foo/ and then capitalize
the already completed input so that you then have Foo/ with the slash?
I can see that one might do that if the name is quite long. And that
use-case would also apply to case-sensitive filesystems.
So fine, let's have if off by default.
> We should only turn it on by default after it has been tested by
> enough users for long enough.
Allright.
BTW, do we need a copyright assignment for this patch? The actual
change is about 5 lines (including reformatting) but the new defcustom
is about a dozen of lines with docstring, and stuff.
Bye,
Tassilo
next prev parent reply other threads:[~2021-09-30 16:48 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 17:50 PR: dired-do-create-files now checks for trailing slashes in the target Rudi C
2021-09-28 18:17 ` Stefan Kangas
2021-09-28 18:42 ` Rudi C
2021-09-28 19:03 ` Stefan Kangas
2021-09-28 19:38 ` Tassilo Horn
2021-09-28 20:07 ` Stefan Kangas
2021-09-28 20:23 ` Rudi C
2021-09-28 18:42 ` Eli Zaretskii
2021-09-28 19:29 ` Tassilo Horn
2021-09-28 19:55 ` Eli Zaretskii
2021-09-29 4:46 ` Tassilo Horn
2021-09-29 13:09 ` Eli Zaretskii
2021-09-29 13:20 ` Rudi C
2021-09-29 13:34 ` Eli Zaretskii
2021-09-29 13:37 ` Tassilo Horn
2021-09-29 13:42 ` Stefan Kangas
2021-09-29 13:53 ` Tassilo Horn
2021-09-29 14:31 ` Rudi C
2021-09-29 13:23 ` Tassilo Horn
2021-09-29 13:41 ` Eli Zaretskii
2021-09-29 13:42 ` Tassilo Horn
2021-09-29 13:57 ` Eli Zaretskii
2021-09-29 14:21 ` Lars Ingebrigtsen
2021-09-29 15:04 ` Stefan Kangas
2021-09-29 15:17 ` Tassilo Horn
2021-09-30 6:06 ` Lars Ingebrigtsen
2021-09-30 7:29 ` Lars Ingebrigtsen
2021-09-30 8:32 ` Tassilo Horn
2021-09-30 13:33 ` Lars Ingebrigtsen
2021-09-30 14:10 ` Tassilo Horn
2021-09-30 16:03 ` Eli Zaretskii
2021-09-30 16:48 ` Tassilo Horn [this message]
2021-09-30 17:47 ` Eli Zaretskii
2021-09-30 18:52 ` Rudi C
2021-09-30 19:02 ` Eli Zaretskii
2021-11-01 15:37 ` Rudi C
2021-11-02 14:44 ` Lars Ingebrigtsen
2021-11-02 15:08 ` Rudi C
2021-11-02 15:15 ` Eli Zaretskii
2021-11-09 12:52 ` Rudi C
2021-11-09 13:47 ` Eli Zaretskii
2021-12-05 12:12 ` Tassilo Horn
2021-12-05 13:26 ` Rudi C
2021-12-05 17:00 ` Tassilo Horn
2021-12-06 4:34 ` Richard Stallman
2021-12-05 20:24 ` Lars Ingebrigtsen
2021-12-06 6:01 ` Tassilo Horn
2021-09-30 15:45 ` [External] : " Drew Adams
2021-09-30 13:54 ` Stefan Kangas
2021-09-30 13:59 ` Lars Ingebrigtsen
2021-09-29 15:44 ` Eli Zaretskii
2021-09-29 17:01 ` [External] : " Drew Adams
2021-09-29 19:09 ` Tassilo Horn
2021-09-29 19:35 ` Drew Adams
2021-09-29 13:57 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7e2vvrp.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=rudiwillalwaysloveyou@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).