From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Thu, 30 Sep 2021 18:48:13 +0200 Message-ID: <87h7e2vvrp.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> <838rzfijnj.fsf@gnu.org> <87r1d73312.fsf@gnu.org> <837deziiwz.fsf@gnu.org> <87ee97bgxt.fsf@gnus.org> <87fstn2ydc.fsf@gnu.org> <87bl4a7g2m.fsf@gnus.org> <87sfxmqwdr.fsf@gnu.org> <87bl4a2nng.fsf@gnus.org> <87lf3ew3k5.fsf@gnu.org> <83wnmyf3u3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33322"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.0; emacs 28.0.50 Cc: larsi@gnus.org, emacs-devel@gnu.org, stefankangas@gmail.com, rudiwillalwaysloveyou@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 30 19:09:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVzZ7-0008Uk-DC for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 19:09:49 +0200 Original-Received: from localhost ([::1]:49332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVzZ6-00037P-9M for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 13:09:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVzVP-0007mB-0G for emacs-devel@gnu.org; Thu, 30 Sep 2021 13:05:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53312) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVzVO-0005bl-Lo; Thu, 30 Sep 2021 13:05:58 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:34785) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVzVG-0007jr-4y; Thu, 30 Sep 2021 13:05:51 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id E401F27C005A; Thu, 30 Sep 2021 13:05:48 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 30 Sep 2021 13:05:48 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekgedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe evveeikeetkeeviefgfeffiedvteeguddvffeuueduveegtddthedvhfeuveffhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Sep 2021 13:05:47 -0400 (EDT) In-reply-to: <83wnmyf3u3.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275917 Archived-At: Eli Zaretskii writes: >> From: Tassilo Horn >> Date: Thu, 30 Sep 2021 16:10:02 +0200 >> Cc: Eli Zaretskii , emacs-devel@gnu.org, >> rudiwillalwaysloveyou@gmail.com, Stefan Kangas >> >> `dired-create-destination-dirs' already exists. But in Rudi's most >> recent patch version, he added a new one. >> >> --8<---------------cut here---------------start------------->8--- >> +(defcustom dired-create-destination-dirs-trailing-separator-special nil > > That's a mouthful, IMO. How about > > dired-create-dirs-with-trailing-slash > > instead? Fine with me. Rudi, could you please rework that suggestion into your latest patch? And please also adjust the docstring of the new option so that it conforms to our conventions, i.e., first line is a complete sentence (try M-x checkdoc RET), and everything is filled at column 70. >> Rudi proposed that the default value should probably be `t' given >> that this feels so intuitive and the only gotcha is renaming/moving >> or copying a directory source/ to a non-existent target or target/ >> where the former has rename/make a copy semantics and the latter has >> move/copy *into* the to be created target/ directory. > > Please don't make it t by default. Ok. > I'm quite sure you didn't consider all the use cases. E.g., what > about foo -> Foo on case-insensitive filesystems? That is a valid use > case where the user wants a directory renamed with a different > letter-case. You mean, you'd TAB-complete to the same name foo/ and then capitalize the already completed input so that you then have Foo/ with the slash? I can see that one might do that if the name is quite long. And that use-case would also apply to case-sensitive filesystems. So fine, let's have if off by default. > We should only turn it on by default after it has been tested by > enough users for long enough. Allright. BTW, do we need a copyright assignment for this patch? The actual change is about 5 lines (including reformatting) but the new defcustom is about a dozen of lines with docstring, and stuff. Bye, Tassilo