Re: Emacs pretest 28.0.91 is out

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Wed, 12 Jan 2022 15:35:42 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> What about trapping errors from ispell-valid-dictionary-list in
    >> lisp/so-long-tests/spelling-tests.el? I mean, my hunspell installation
    >> is borked, because brew on macOS doesnʼt install any dictionaries by
    >> default, so itʼs not entirely a test suite issue.

    Eli> I'm not sure I understand what errors you allude to.  Can you tell
    Eli> more?  (spelling-tests.el skips all tests on my machine, it seems
    Eli> because the test expects Ispell-style dictionary names, which doesn't
    Eli> work with Hunspell.)

From my original message:

Debugger entered--Lisp error: (error "Can't find Hunspell dictionary with a .aff affix f...")
  signal(error ("Can't find Hunspell dictionary with a .aff affix f..."))
  error("Can't find Hunspell dictionary with a .aff affix f...")
  ispell-find-hunspell-dictionaries()
  ispell-set-spellchecker-params()
  ispell-valid-dictionary-list()
  byte-code("\301\302!\210\301\303!\210\301\304!\210\10\203>\0\305\10!\203>\0\3061\"\0\307 \210\3100\202&\0\210\202>\0\203>\0\311\312 \235\203>\0\313\314..." [ispell-program-name require ert ispell cl-lib executable-find (error) ispell-check-version t "british" ispell-valid-dictionary-list ert-set-test so-long-spelling record ert-test "Check the spelling in the source code." #f(compiled-function () #<bytecode 0x63d714e81979f10>) nil :passed (:unstable)] 10)
  load("lisp/so-long-tests/spelling-tests" nil t)

This is because I have no hunspell dictionaries at all (and it would
be cleaner to define the test unconditionally, but skip it when
needed, but thatʼs another discussion).

Robert
--