unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs pretest 28.0.91 is out
Date: Tue, 11 Jan 2022 12:43:55 +0100	[thread overview]
Message-ID: <877db65wg4.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmm1-qstLz2B80_wEZH3FjvAfdg-+2W1eMQg6J-6_wC7mw__6229.00487376086$1641854896$gmane$org@mail.gmail.com> (Stefan Kangas's message of "Mon, 10 Jan 2022 16:39:40 -0600")

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

>>>>> On Mon, 10 Jan 2022 16:39:40 -0600, Stefan Kangas <stefan@marxist.se> said:

    Stefan> Hi!
    Stefan> The second pretest for what will be the 28.1 release of Emacs (the
    Stefan> extensible text editor) is available at:

    Stefan>   https://alpha.gnu.org/gnu/emacs/pretest/emacs-28.0.91.tar.xz

I get three test failures on macOS with this (and zero on
GNU/Linux). The spelling test one is because I think my hunspell
installation is broken, but we can guard against it (see attached
patch). The other two I suspect are because 'gcc' here is 'clang', not
real gcc, so maybe those tests need to check for that. Logs attached.


1 files did not contain any tests:
  lisp/so-long-tests/spelling-tests.log
2 files contained unexpected results:
  lisp/progmodes/flymake-tests.log
  lisp/cedet/semantic/bovine/gcc-tests.log
make[2]: *** [check-doit] Error 2
make[1]: *** [check] Error 2
make: *** [check] Error 2


Robert
-- 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-spelling-tests.el-trap-error.patch --]
[-- Type: text/x-diff, Size: 1240 bytes --]

From f7129d54b258cfaf5de374e7cc2c678c5bf490eb Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 11 Jan 2022 12:20:44 +0100
Subject: [PATCH] spelling-tests.el: trap error
To: emacs-devel@gnu.org

'ispell-valid-dictionary-list' can signal an error, so guard against
that.

* test/lisp/so-long-tests/spelling-tests.el (so-long-spelling): Wrap
check for ispell-valid-dictionary-list in condition-case.
---
 test/lisp/so-long-tests/spelling-tests.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/lisp/so-long-tests/spelling-tests.el b/test/lisp/so-long-tests/spelling-tests.el
index eb1014dd8a..837ccd5600 100644
--- a/test/lisp/so-long-tests/spelling-tests.el
+++ b/test/lisp/so-long-tests/spelling-tests.el
@@ -40,7 +40,9 @@
            (condition-case ()
                (progn (ispell-check-version) t)
              (error nil))
-           (member "british" (ispell-valid-dictionary-list)))
+           (condition-case ()
+               (member "british" (ispell-valid-dictionary-list))
+             (error nil)))
   (ert-deftest so-long-spelling ()
     "Check the spelling in the source code."
     :tags '(:unstable) ;; It works for me, but I'm not sure about others.
-- 
2.34.0


[-- Attachment #3: spelling-tests.log --]
[-- Type: application/octet-stream, Size: 1437 bytes --]

Debugger entered--Lisp error: (error "Can't find Hunspell dictionary with a .aff affix f...")
  signal(error ("Can't find Hunspell dictionary with a .aff affix f..."))
  error("Can't find Hunspell dictionary with a .aff affix f...")
  ispell-find-hunspell-dictionaries()
  ispell-set-spellchecker-params()
  ispell-valid-dictionary-list()
  byte-code("\301\302!\210\301\303!\210\301\304!\210\10\203>\0\305\10!\203>\0\3061\"\0\307 \210\3100\202&\0\210\202>\0\203>\0\311\312 \235\203>\0\313\314..." [ispell-program-name require ert ispell cl-lib executable-find (error) ispell-check-version t "british" ispell-valid-dictionary-list ert-set-test so-long-spelling record ert-test "Check the spelling in the source code." #f(compiled-function () #<bytecode 0x63d714e81979f10>) nil :passed (:unstable)] 10)
  load("lisp/so-long-tests/spelling-tests" nil t)
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/" "-l" "./../../elpa/packages/url-http-ntlm/url-http-ntlm...." "-L" "./../../elpa/packages/web-server/" "-l" "./../../elpa/packages/web-server/web-server.el" "-l" "ert" "-L" "./../../elpa/packages/url-http-ntlm/" "-l" "./../../elpa/packages/url-http-ntlm/url-http-ntlm...." "-L" "./../../elpa/packages/web-server/" "-l" "./../../elpa/packages/web-server/web-server.el" "-l" "lisp/so-long-tests/spelling-tests" "--eval" "(ert-run-tests-batch-and-exit (quote (not (or (tag..."))
  command-line()
  normal-top-level()


[-- Attachment #4: flymake-tests.log --]
[-- Type: application/octet-stream, Size: 3141 bytes --]

Running 9 tests (2022-01-11 12:26:52+0100, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
Test different-diagnostic-types backtrace:
  signal(ert-test-failed (((should (eq 'flymake-error (face-at-point))
  ert-fail(((should (eq 'flymake-error (face-at-point))) :form (eq fly
  #f(compiled-function () #<bytecode -0x899aa44f89dbfa>)()
  flymake-tests--call-with-fixture(#f(compiled-function () #<bytecode 
  #f(compiled-function () #<bytecode -0x6f84e02efe25893>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name different-diagnostic-types :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...))
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test different-diagnostic-types condition:
    (ert-test-failed
     ((should
       (eq 'flymake-error
	    (face-at-point)))
      :form
      (eq flymake-error flymake-warning)
      :value nil))
   FAILED  1/9  different-diagnostic-types (1.172453 sec)
   passed  2/9  dummy-backends (1.004546 sec)
   passed  3/9  eob-region-and-trailing-newline (0.000231 sec)
Test included-c-header-files backtrace:
  signal(ert-test-failed (((should (eq 'flymake-error (face-at-point))
  ert-fail(((should (eq 'flymake-error (face-at-point))) :form (eq fly
  #f(compiled-function () #<bytecode 0x6b624c6b834498c>)()
  flymake-tests--call-with-fixture(#f(compiled-function () #<bytecode 
  #f(compiled-function () #<bytecode 0x1b9738f3fe49e06d>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name included-c-header-files :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test included-c-header-files condition:
    (ert-test-failed
     ((should
       (eq 'flymake-error
	    (face-at-point)))
      :form
      (eq flymake-error flymake-warning)
      :value nil))
   FAILED  4/9  included-c-header-files (1.061344 sec)
   passed  5/9  perl-backend (1.037435 sec)
   passed  6/9  recurrent-backend (1.011210 sec)
   passed  7/9  ruby-backend (1.049725 sec)
   passed  8/9  warning-predicate-function-gcc (1.075085 sec)
   passed  9/9  warning-predicate-rx-gcc (1.063238 sec)

Ran 9 tests, 7 results as expected, 2 unexpected (2022-01-11 12:27:01+0100, 8.685472 sec)

2 unexpected results:
   FAILED  different-diagnostic-types
   FAILED  included-c-header-files


[-- Attachment #5: gcc-tests.log --]
[-- Type: application/octet-stream, Size: 1641 bytes --]

Running 2 tests (2022-01-11 12:25:00+0100, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
   passed  1/2  semantic-gcc-test-output-parser (0.000334 sec)
Test semantic-gcc-test-output-parser-this-machine backtrace:
  signal(error ("Test failed on \"Configured with: --prefix=/Library..
  error("Test failed on %S\nV H P:\n%S %S %S" "Configured with: --pref
  semantic-gcc-test-output-parser()
  #f(compiled-function () #<bytecode 0x1f3bfaba4f5f647f>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name semantic-gcc-test-output-parser-this-
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test semantic-gcc-test-output-parser-this-machine condition:
    (error "Test failed on \"Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1\"\nV H P:\nnil \"x86_64-apple-darwin20.6.0\" nil")
   FAILED  2/2  semantic-gcc-test-output-parser-this-machine (0.029720 sec)

Ran 2 tests, 1 results as expected, 1 unexpected (2022-01-11 12:25:01+0100, 0.114861 sec)

1 unexpected results:
   FAILED  semantic-gcc-test-output-parser-this-machine


       reply	other threads:[~2022-01-11 11:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADwFkmm1-qstLz2B80_wEZH3FjvAfdg-+2W1eMQg6J-6_wC7mw__6229.00487376086$1641854896$gmane$org@mail.gmail.com>
2022-01-11 11:43 ` Robert Pluim [this message]
2022-01-11 12:50   ` Emacs pretest 28.0.91 is out Michael Albinus
2022-01-11 13:25     ` Robert Pluim
2022-01-11 14:14   ` Robert Pluim
2022-01-11 17:06     ` Eli Zaretskii
2022-01-11 17:45       ` Robert Pluim
2022-01-11 18:38         ` Eli Zaretskii
2022-01-12  8:28           ` Robert Pluim
2022-01-12 13:35             ` Eli Zaretskii
2022-01-12 14:15               ` Robert Pluim
2022-01-12 14:22                 ` Eli Zaretskii
2022-01-12 14:33                   ` Robert Pluim
2022-01-12 15:03                     ` Eli Zaretskii
2022-01-12 11:24         ` Michael Albinus
2022-01-12 12:59           ` Robert Pluim
2022-01-12 13:11             ` Michael Albinus
2022-01-10 22:39 Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877db65wg4.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).