From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481) Date: Thu, 19 May 2022 09:09:37 +0800 Message-ID: <87h75ml44u.fsf@yahoo.com> References: <165286472597.14890.11407291537527786185@vcs2.savannah.gnu.org> <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org> <87y1yzkvvu.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30154"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 03:10:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrUgT-0007gc-5X for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 03:10:33 +0200 Original-Received: from localhost ([::1]:50774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrUgS-000673-6n for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 21:10:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrUfn-0005O1-Ah for emacs-devel@gnu.org; Wed, 18 May 2022 21:09:51 -0400 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:40950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrUfl-000580-K8 for emacs-devel@gnu.org; Wed, 18 May 2022 21:09:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652922587; bh=+t3u5O0Uoio4/Kws1MhpoqaXZU+pB9CCDTYiJDxrlGA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=jf+indrC4DOnyAUOomBggNzbed2vmArfNcHRm7QqL4of3zuHCEAJamBBRrwDRp1e0OCSjNdk83ea6YEHVXcpHPyZ4DuWPQC9N0iCQYM9aNBkBU/kpy7jUvnFv7vcPwq36I1wYdub3Du6YisWKskhqGOCSts6l0HMNhlfWbPv5MmGq7kUJT3a1BFTRvOi9Tak1pGboITAr6wVhe9/qgFGUOckGqCItSAssX2gKnqJE9eKIY0TZdC8fAmUTlR9obNwdwoNCgC6U59nr74VutOsFeRXvXeMSRVwD0E/RNeBA3VOhTHHFOYx5unSsbfxVY7D+Lc7i3WC0o5rjh9A3e0ZKg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652922587; bh=5OFSACpNwzRdA8fMMuGDIC/EK8VV8XsGzTMRqQIDXkd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XShV6Sp6aLLXFuIBS8itRHIZ2BIwmr3d7ROg8wdlDo9A4X8+piSd+37UbP5ii9+UTK51rSM9lwVGvugyzBVHrifu96fOSfhYedsvjDcJWlqFAHX1FhExF3NeqfDv1gb4ztiymRaJ22tBYEHrJ43yBIpFcHKUJr5WJ1WhsZN7fxP76O8vuTx4EprPuFhh0R/kq4mqxLwufvZ56pTY4yWr52JFfN0SiaheEwClH7Jm0DkPi9b7yNOnYNE+rlsc/hc7M0h0SIL7p+oDffiarTQ/tYOguK82o6CjHe6oi9aCDL5yI7iYva4sjbnUWSZUEcRBRbU2ImKu/VxMXiwavnjlIA== X-YMail-OSG: hyaq0msVM1kNwXRvCUj2i9GAD7DzEzUAPzI10NfIExd4lQhBMqlJcw1AeSthema 6nP8swGDNZidmF7Wu5xf3UY7YHo8TReByIZ.0MJgw_IOfr8mHb6AmKRhn.CbUIJvSE2g_2YPMmOd Xn7EniYRKrZ7Ci7Xk3duH.y.LiW.FadGod.GVLrq_xLn3KLqFMdo0bVTx6rpoYwAdoM65Mgjve.D aw9KaVtUHkQJC.EcucFMs9E5KuTL3NcSbRLFJrF9HMGoF6ENoTRypOte5URjfozmUFlMNgJ3Wbcf rvFVMkOTrT5vVfuSJ9HN6nLjTVhweQjMFXIeq9UD2wDJOCfdRIW35hk1jR_acMVRP0bI3lsFrcL1 1GsdFa7UeoWpLnUn0buDNjfu4s0yTfiD9pXfekUM60R3Mf8LYzcJKkQJxODVYejd.4qmzwbvJ7r5 CvRylpON9AA2ROnQH96T0NmzlmiC56Z9c2B2Q5Ek7O7xKfYVx.K3UcQQ3ffGJxfLwKH6lS_jtKJZ F.W6v1.JziA7khj0fAghsrG.CmBMSirfanWsqWTN2JcE578CtNirdo1h6XyjPcVABD3I2MlLxRkT 4bI23UiuWmuwMDEMKBqP06PmIESRAOfeEphg3HRl7jzfotMwwK4dO8NbxytJLzXi0aLS5i0arBv7 61OMppQZHsqwZ.tjxpkK7coXSOx_ROS0DElQbzDoDNIvU3MFVt4TnSJoPqUyUecB3I6xtbayL8a9 t1uhsbqwW3d.Cx6t4aO6IHUBYXQB7BAesU48AHtYRWKEVoO39VQxXKUT8zF.hJQ7ybeeRnb1wkzd iSUhpC087uOQuUntZl3g_xaD4dntcr1odOMqJ7_fq9 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Thu, 19 May 2022 01:09:47 +0000 Original-Received: by hermes--canary-production-sg3-78f9b9c87b-br5zq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4fbf3dd52640e63e0034cf75f94e8071; Thu, 19 May 2022 01:09:41 +0000 (UTC) In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 18 May 2022 16:40:39 +0200") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.84; envelope-from=luangruo@yahoo.com; helo=sonic306-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289947 Archived-At: Mattias Engdeg=C3=A5rd writes: > I wasn't sure and there appeared to be considerable variation in the > existing source (almost 300 cases of bracket on the same line, against > 500-something with the bracket on a separate line), so I went with the > former since it is more economic in vertical space without worsening > readability. Unfortunately, that contradicts our own coding standards. > Naturally I'll change if that is important, but then there's a lot of > code to change, and apparently there is no clear consensus among > previous authors. All of that code is formatted incorrectly, but reformatting existing code breaks various things, such as vc-annotate. What I think is wrong is to introduce new instances of the incorrect formatting (such as here), since our coding standards say: For struct and enum types, likewise put the braces in column one, unless the whole contents fits on one line: struct foo { int a, b; } or struct foo { int a, b; }