From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Date: Mon, 14 Nov 2022 20:20:53 +0100 Message-ID: <87h6z1l4ve.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5427"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Randy Taylor , Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 02:02:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oukLf-0001AZ-AH for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 02:02:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouijP-0003MX-SK; Mon, 14 Nov 2022 18:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouieP-0002E1-DX for emacs-devel@gnu.org; Mon, 14 Nov 2022 18:14:02 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouf0w-0005h4-HU for emacs-devel@gnu.org; Mon, 14 Nov 2022 14:21:09 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668453660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=UC1gWjXNAKsuR7ZoR/xkzdJ3cjrlMihokFJbfPBJR0w=; b=VMrRlilvfbxEszP2BTJYDuHdRiT7XAGjm9FFlWdR2Zcgc89dAAW6Nm03yaUi1iJViBhGkJ VKA8tbzMPra6HCOlwk+744LSq639Q+PFgKveoNoVV/CC3A6k+P/EWzWhlfGxnhuxDCwSOV vRGWW0XdoeII6I8BJESsww97J95/QegVaTUDMV3jn97EhNBGtHkgfbo0RqGHk1/URyTxER jga2CoXl5OrBxZGpqF/rNTXkDyj9JgE8wHeMWVC/JpPVJBrwHfuAvyCraXx3zt38HeLXIv JP19XUHV6h+nFrxCXF1fr4dlgjEQKObcpHawZjbLnxtBZIgLoXtmR2fFFn9YDg== X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299805 Archived-At: (adding back in emacs-devel) Randy Taylor writes: > Hey guys, > > Seems like the mailing lists are down from what I can tell, so just > sending the patch I sent out yesterday in case either of you wanted to > take a look. Not sure how long the lists will be down for (or even > what's going on). > > BTW I think it would be a good idea to figure out some guidelines for > the tree-sitter features (and write them down somewhere) - some that > are applicable to as many languages as possible, and preferably as > small as possible. That way we can have consistent implementations, > and languages can deviate where they may need to. I will think about > composing a list of what we may want. > I think that's smart, but I envision we will diverge in any case, hehe. > Here's what I said in the email: > I'm just submitting C/C++ and Python for now since some of the other files are > a little more volatile currently (there are some patches in progress). > I like it! Are you sure we cover most of the stuff that was covered in the old style? I see it is different visually, but that's likely the new faces are without any color, right? I think you should add similar changes to all the new modes: - ts-mode - json-ts-mode - css-ts-mode - java-ts-mode - js-mode If you have time and energy, of course :-) Theo