* Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices):
[not found] <E1VGx0J-0005JS-O6@vcs.savannah.gnu.org>
@ 2013-09-06 9:41 ` Michael Albinus
2013-09-06 13:04 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2013-09-06 9:41 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
> message:
> * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices):
> * lisp/net/tramp-smb.el (tramp-smb-get-file-entries):
> * lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory)
> (tramp-compute-multi-hops): Fix misuses of `add-to-list'.
With this change (replacing `add-to-list' by `pushnew') I get compiler
warnings like this:
--8<---------------cut here---------------start------------->8---
emacs24 --no-site-file -batch -l bytecomp \
--eval "(add-to-list 'load-path default-directory)" \
-f batch-byte-compile tramp-sh.el
In tramp-compute-multi-hops:
tramp-sh.el:4277:31:Warning: function `adjoin' from cl package called at
runtime
emacs24 --no-site-file -batch -l bytecomp \
--eval "(add-to-list 'load-path default-directory)" \
-f batch-byte-compile tramp-gvfs.el
In tramp-synce-list-devices:
tramp-gvfs.el:1718:38:Warning: function `adjoin' from cl package called at
runtime
--8<---------------cut here---------------end--------------->8---
This does not happen for the trunk version, but for older Emacsen (like
24.2, used in this example).
Is your change worth the trouble? And if yes, how to handle those warnings?
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices):
2013-09-06 9:41 ` trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices): Michael Albinus
@ 2013-09-06 13:04 ` Stefan Monnier
2013-09-06 14:23 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2013-09-06 13:04 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> This does not happen for the trunk version, but for older Emacsen (like
> 24.2, used in this example).
Then we should replace them with their expansion:
(unless (member x l) (push x l))
Of course, maybe for some of them you know that (member x l) is always
nil, in which case you can just use `push'.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices):
2013-09-06 13:04 ` Stefan Monnier
@ 2013-09-06 14:23 ` Michael Albinus
0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2013-09-06 14:23 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Then we should replace them with their expansion:
> (unless (member x l) (push x l))
> Of course, maybe for some of them you know that (member x l) is always
> nil, in which case you can just use `push'.
Will do.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-06 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1VGx0J-0005JS-O6@vcs.savannah.gnu.org>
2013-09-06 9:41 ` trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices): Michael Albinus
2013-09-06 13:04 ` Stefan Monnier
2013-09-06 14:23 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).