From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices): Date: Fri, 06 Sep 2013 11:41:30 +0200 Message-ID: <87k3iu4791.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378460510 11739 80.91.229.3 (6 Sep 2013 09:41:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Sep 2013 09:41:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 06 11:41:52 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHsY3-0000Nt-Cb for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 11:41:51 +0200 Original-Received: from localhost ([::1]:36211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHsY2-0006zz-Nl for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 05:41:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHsXt-0006y2-Ps for emacs-devel@gnu.org; Fri, 06 Sep 2013 05:41:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHsXn-00089s-V8 for emacs-devel@gnu.org; Fri, 06 Sep 2013 05:41:41 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:61547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHsXn-00089B-MH for emacs-devel@gnu.org; Fri, 06 Sep 2013 05:41:35 -0400 Original-Received: from detlef.gmx.de ([91.41.128.14]) by mail.gmx.com (mrgmx003) with ESMTPS (Nemesis) id 0LqiJO-1Vvu813raU-00eMz0 for ; Fri, 06 Sep 2013 11:41:32 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 03 Sep 2013 20:15:11 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:19NB4Ryi2YTj9gXJvRIGELZgg2rqj2bUUzXNPMInK+XJil8Mhil O6Eg9neNCD57quQxrBAT5HC97CKiXuEVenmaFslb3n4uMtTVNfHxo7L5jJpZTYvcbIRw/T+ ue7R11r5PdYnYZ2NCKq9/YboDBo0NYHOBv1Nn6tZCKbGSWgx40V0o+pdToZhdf2iD0Gcf0r 2/lSJ0aHFwZQzMBBjsIbg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163211 Archived-At: Stefan Monnier writes: Hi Stefan, > message: > * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices): > * lisp/net/tramp-smb.el (tramp-smb-get-file-entries): > * lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory) > (tramp-compute-multi-hops): Fix misuses of `add-to-list'. With this change (replacing `add-to-list' by `pushnew') I get compiler warnings like this: --8<---------------cut here---------------start------------->8--- emacs24 --no-site-file -batch -l bytecomp \ --eval "(add-to-list 'load-path default-directory)" \ -f batch-byte-compile tramp-sh.el In tramp-compute-multi-hops: tramp-sh.el:4277:31:Warning: function `adjoin' from cl package called at runtime emacs24 --no-site-file -batch -l bytecomp \ --eval "(add-to-list 'load-path default-directory)" \ -f batch-byte-compile tramp-gvfs.el In tramp-synce-list-devices: tramp-gvfs.el:1718:38:Warning: function `adjoin' from cl package called at runtime --8<---------------cut here---------------end--------------->8--- This does not happen for the trunk version, but for older Emacsen (like 24.2, used in this example). Is your change worth the trouble? And if yes, how to handle those warnings? Best regards, Michael.