From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: Karl Fogel <kfogel@red-bean.com>, Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Should `revert-buffer' preserve text-scaling by default?
Date: Sun, 01 Dec 2019 11:27:08 +0100 [thread overview]
Message-ID: <87fti4cpdv.fsf@gmx.de> (raw)
In-Reply-To: <CADwFkmmYG+XNwXiCd7S+XRhShd9CEPZA4q5xN=cUQkiTgZaStA@mail.gmail.com> (Stefan Kangas's message of "Sun, 1 Dec 2019 10:47:28 +0100")
Stefan Kangas <stefan@marxist.se> writes:
>> So going back to the previous proposal seems like the best approach,
>> because it allows us to change just the buggy behavior(s) and
>> nothing else. To reiterate: that proposal is to have a new list
>> variable `revert-buffer-preserved-modes', whose default value
>> includes these modes:
>>
>> `text-scale-mode'
>> `display-line-numbers-mode'
>> `display-fill-column-indicator-mode'
>> `hl-line-mode' (maybe?)
>>
>> Over time we could adjust the default contents of this list, of course.
>>
>> I would also like to hear what others here think, both about the overall idea and about what modes should be in that list.
>
> Since you are asking for opinions:
>
> The bug you originally mentioned with text-scale-mode and
> revert-buffer is incredibly frustrating. I incorrectly assumed there
> was a good reason for the behaviour, and never bothered looked into
> it. So thank you for doing that.
>
> I agree that all four modes above should stay enabled on
> revert-buffer, including hl-line-mode.
I haven't tested, but wouldn't it be sufficient if these minor modes
add the `permanent-local' property to their buffer-local variables?
> Best regards,
> Stefan Kangas
Best regards, Michael.
next prev parent reply other threads:[~2019-12-01 10:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 20:24 Should `revert-buffer' preserve text-scaling by default? Karl Fogel
2019-11-29 20:39 ` Eli Zaretskii
2019-11-29 21:02 ` Karl Fogel
2019-11-30 7:24 ` Eli Zaretskii
2019-11-29 21:09 ` Stefan Monnier
2019-11-29 21:20 ` Karl Fogel
2019-11-30 7:22 ` Eli Zaretskii
2019-12-01 8:15 ` Karl Fogel
2019-12-01 9:47 ` Stefan Kangas
2019-12-01 10:24 ` Juanma Barranquero
2019-12-01 17:38 ` Eli Zaretskii
2019-12-01 10:27 ` Michael Albinus [this message]
2019-12-01 17:35 ` Karl Fogel
2019-12-01 18:25 ` Stefan Monnier
2019-12-02 2:01 ` Karl Fogel
2019-12-02 16:15 ` Eli Zaretskii
2019-12-02 17:19 ` Karl Fogel
2019-12-02 17:42 ` Eli Zaretskii
2019-12-02 22:29 ` Karl Fogel
2019-12-02 22:49 ` Stefan Monnier
2019-12-03 0:36 ` Karl Fogel
2019-12-03 16:11 ` Eli Zaretskii
2019-12-03 16:10 ` Eli Zaretskii
2019-12-03 16:09 ` Eli Zaretskii
2019-12-03 17:35 ` Karl Fogel
2019-12-01 21:49 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fti4cpdv.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).