Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files.

Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files.

[Philip Kaludercic]

Stefan Kangas <stefankangas@gmail.com> writes:

> branch: main
> commit 643497b885a863341abc933313343f6056a78e2a
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     * elpa-packages (xml-rpc): Include test files.

Why are the files included in the package?

> ---
>  elpa-packages | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elpa-packages b/elpa-packages
> index 5ff9689965..d2641b1aa5 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -662,7 +662,7 @@
>  
>   ("xml-rpc"             :url "https://github.com/xml-rpc-el/xml-rpc-el.git"
>    :readme "README.org"
> -  :ignored-files ("LICENSE" ".github" "Makefile" "xml-rpc-test.el"))
> +  :ignored-files ("LICENSE" ".github"))
>  
>   ("yaml-mode"		:url "https://github.com/yoshiki/yaml-mode"
>    :ignored-files ("LICENSE.txt" "test-files" "Makefile")

Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files.

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> Why are the files included in the package?

I was under the impression that we thought such files might as well be
included.  Am I mistaken?

Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files.

[Stefan Monnier]

Stefan Kangas [2022-10-04 21:46:06] wrote:
> Philip Kaludercic <philipk@posteo.net> writes:
>> Why are the files included in the package?
> I was under the impression that we thought such files might as well be
> included.  Am I mistaken?

Yes, we generally prefer to err on the side of including too much.
If the author wants to exclude more, of course, that's their
prerogative, but the better place to do it is in `.elpaignore`.


        Stefan

Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files.

[Philip Kaludercic]

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Why are the files included in the package?
>
> I was under the impression that we thought such files might as well be
> included.  Am I mistaken?

I don't know if there is a guideline, but I've been removing test files
as developing (and testing) a package that was downloaded as a tarball
without version control information seems to make little sense to me.