* Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files. [not found] ` <20221004164037.E6F95C11D79@vcs2.savannah.gnu.org> @ 2022-10-04 17:45 ` Philip Kaludercic 2022-10-04 19:46 ` Stefan Kangas 0 siblings, 1 reply; 4+ messages in thread From: Philip Kaludercic @ 2022-10-04 17:45 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Kangas Stefan Kangas <stefankangas@gmail.com> writes: > branch: main > commit 643497b885a863341abc933313343f6056a78e2a > Author: Stefan Kangas <stefankangas@gmail.com> > Commit: Stefan Kangas <stefankangas@gmail.com> > > * elpa-packages (xml-rpc): Include test files. Why are the files included in the package? > --- > elpa-packages | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elpa-packages b/elpa-packages > index 5ff9689965..d2641b1aa5 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -662,7 +662,7 @@ > > ("xml-rpc" :url "https://github.com/xml-rpc-el/xml-rpc-el.git" > :readme "README.org" > - :ignored-files ("LICENSE" ".github" "Makefile" "xml-rpc-test.el")) > + :ignored-files ("LICENSE" ".github")) > > ("yaml-mode" :url "https://github.com/yoshiki/yaml-mode" > :ignored-files ("LICENSE.txt" "test-files" "Makefile") ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files. 2022-10-04 17:45 ` [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files Philip Kaludercic @ 2022-10-04 19:46 ` Stefan Kangas 2022-10-04 20:10 ` Stefan Monnier 2022-10-04 20:25 ` Philip Kaludercic 0 siblings, 2 replies; 4+ messages in thread From: Stefan Kangas @ 2022-10-04 19:46 UTC (permalink / raw) To: Philip Kaludercic; +Cc: emacs-devel Philip Kaludercic <philipk@posteo.net> writes: > Why are the files included in the package? I was under the impression that we thought such files might as well be included. Am I mistaken? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files. 2022-10-04 19:46 ` Stefan Kangas @ 2022-10-04 20:10 ` Stefan Monnier 2022-10-04 20:25 ` Philip Kaludercic 1 sibling, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2022-10-04 20:10 UTC (permalink / raw) To: Stefan Kangas; +Cc: Philip Kaludercic, emacs-devel Stefan Kangas [2022-10-04 21:46:06] wrote: > Philip Kaludercic <philipk@posteo.net> writes: >> Why are the files included in the package? > I was under the impression that we thought such files might as well be > included. Am I mistaken? Yes, we generally prefer to err on the side of including too much. If the author wants to exclude more, of course, that's their prerogative, but the better place to do it is in `.elpaignore`. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files. 2022-10-04 19:46 ` Stefan Kangas 2022-10-04 20:10 ` Stefan Monnier @ 2022-10-04 20:25 ` Philip Kaludercic 1 sibling, 0 replies; 4+ messages in thread From: Philip Kaludercic @ 2022-10-04 20:25 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel Stefan Kangas <stefankangas@gmail.com> writes: > Philip Kaludercic <philipk@posteo.net> writes: > >> Why are the files included in the package? > > I was under the impression that we thought such files might as well be > included. Am I mistaken? I don't know if there is a guideline, but I've been removing test files as developing (and testing) a package that was downloaded as a tarball without version control information seems to make little sense to me. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-04 20:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166490163754.4311.14298768127254276223@vcs2.savannah.gnu.org>
[not found] ` <20221004164037.E6F95C11D79@vcs2.savannah.gnu.org>
2022-10-04 17:45 ` [nongnu] main 643497b885: * elpa-packages (xml-rpc): Include test files Philip Kaludercic
2022-10-04 19:46 ` Stefan Kangas
2022-10-04 20:10 ` Stefan Monnier
2022-10-04 20:25 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).