From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Tue, 15 Nov 2022 19:18:35 +0000 Message-ID: <87edu458ms.fsf@posteo.net> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> <87r0zib5d4.fsf@melete.silentflame.com> <87y1tqp6l6.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 20:19:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ov1T7-0005rl-9h for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 20:19:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ov1SK-0000FE-32; Tue, 15 Nov 2022 14:18:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov1SH-0000E4-Ct for emacs-devel@gnu.org; Tue, 15 Nov 2022 14:18:45 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov1SF-00069p-Bt for emacs-devel@gnu.org; Tue, 15 Nov 2022 14:18:45 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BCC58240027 for ; Tue, 15 Nov 2022 20:18:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668539918; bh=/AsZc6P8mm3IFzsu/raoHd9Cserp9kcTMVlTs4BPO6g=; h=From:To:Cc:Subject:Date:From; b=mKLnOgs0o5I1yO4K37RQjAUHZ0T6M+ax3SiE+5rZHUrNqv3xmGfyFA1rtGzB9qVVp 556Al4dpVy4eYAM5nxy+n6WXOUH1HudYH1M+E9X7tVPpN5G/qIMtDHH82n7/P8ZQuS VqMYDajFlBWBwDy3MVPLdfwGZ5cqbGgSohNaHPiiYzzewQutsEQsy7Iy9uCwS4g83k BGeprA1/LLBXntJQxlWLIV3Y94Im7PZe5uHXov802DQI5p4ywifwGi6VLhmuPxmYk8 hVJgH+X2O9ONh+5GO0DO6+wz5fkWZtDFM83rOvnMn6HFCgrnVasZCb8Ww78UUeJwPv Mii8UB07S1oGQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NBbZ51tMjz9rxM; Tue, 15 Nov 2022 20:18:34 +0100 (CET) In-Reply-To: <87y1tqp6l6.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 08 Oct 2022 19:29:09 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299877 Archived-At: Philip Kaludercic writes: > Sean Whitton writes: > >> Hello, >> >> On Sat 08 Oct 2022 at 05:52AM -04, Philip Kaludercic wrote: >> >>> +@vindex vc-prepare-patches-separately >>> +Depending on the value of the user option >>> +@code{vc-prepare-patches-separately}, @code{vc-prepare-patch} will >>> +generate one or more messages. The default value @code{t} means >>> +prepare and display a message for each revision, one after another. A >>> +value of @code{nil} means to generate a single message with all >>> +patches attached in the body. >>> + >>> +@vindex vc-default-patch-addressee >>> +If you expect to contribute patches on a regular basis, you can set >>> +the user option @code{vc-default-patch-addressee} to the address(es) >>> +you wish to use. This will be used as the default value when invoking >>> +@code{vc-prepare-patch}. Project maintainers may consider setting >>> +this as a directory local variable (@pxref{Directory Variables}). >>> + >> >> Please excuse me if I missed discussion in a bug, but wouldn't it make >> sense to set *both* of these in .dir-locals.el for emacs.git? > > Yes, but I would wait a bit to avoid the same issues as we had when > `diff-add-log-use-relative-names' was set. Anyone who had pulled the > new commits with the change but hadn't rebuilt Emacs to know that these > are safe values was prompted the "are you sure these variables are safe" > queries. If we wait for a week or two then I would guess that most > people following development will have pulled and rebuilt at least once > by then. I guess enough time has gone by and the variable could be added to .dir-locals.el?