From: Lars Ingebrigtsen <larsi@gnus.org>
To: akater <nuclearspace@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [PATCH] Some improvements for cl-flet
Date: Sun, 26 Sep 2021 08:54:06 +0200 [thread overview]
Message-ID: <87czovsu7l.fsf@gnus.org> (raw)
In-Reply-To: <87k0j6gbjg.fsf@gmail.com> (akater's message of "Thu, 23 Sep 2021 22:41:23 +0000")
akater <nuclearspace@gmail.com> writes:
> Fixes the following issues with cl-flet:
> - No error on illegal function names
> - No error on malformed specs
> - Incorrectly treated (setf ..) local functions
> - No warning on duplicated definitions
> - No warning on unused definitions
> - No way to capture definitions present in the body
Sounds great. :-) I don't have any comments on the actual
functionality, but just a couple of trivial notes:
> -(defmacro cl--generic-with-memoization (place &rest code)
> +(defmacro cl--with-memoization (place &rest code)
Is there any reason for this renaming?
> +(defun cl--flet-convert-with-setf (f)
> + "Special macro-expander to rename (function F) references in `cl-flet', including (function (setf F)).
The first line of the doc string should be a complete sentence (shorter
than 80 characters).
> +(defmacro with--cl-flet-macroexp ( arglist var
> + function-name expander memoized-alist
> + &rest body)
> + "Return lambda (with ARGLIST being its arglist) that can
> +serve as a macroexpanding function in
> +`macroexpand-all-environment' to expand local function calls of
> +the form (FUNCTION-NAME ..).
Ditto (and the same for a couple more macros).
Anyway, this sounds like good improvement for cl-flet, but I think it'll
have to wait until Emacs 29 -- it's a too big a change to go into Emacs
28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-26 6:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 12:51 Some improvements for cl-flet akater
2021-09-11 23:32 ` Michael Heerdegen
2021-09-12 3:35 ` akater
2021-09-12 15:38 ` Stefan Monnier
2021-09-13 0:14 ` Michael Heerdegen
2021-09-13 2:26 ` Stefan Monnier
2021-10-07 2:32 ` akater
2021-10-07 18:03 ` Stefan Monnier
2021-10-08 21:57 ` Richard Stallman
2021-10-09 5:23 ` akater
2021-10-09 6:01 ` Michael Heerdegen
2021-10-09 23:37 ` Richard Stallman
2021-10-10 10:41 ` Po Lu
2021-10-10 20:27 ` João Távora
2021-10-10 21:57 ` Stefan Monnier
2021-10-11 0:45 ` [External] : " Drew Adams
2021-10-11 21:16 ` Richard Stallman
2021-10-11 21:26 ` João Távora
2021-10-12 22:42 ` Richard Stallman
2021-10-12 0:05 ` Po Lu
2021-10-12 0:29 ` Robin Tarsiger
2021-10-12 22:43 ` Richard Stallman
2021-10-09 23:33 ` Richard Stallman
2021-10-09 23:33 ` Richard Stallman
2021-10-14 4:00 ` Michael Heerdegen
2021-09-23 22:37 ` [PATCH] " akater
2021-09-23 22:41 ` akater
2021-09-24 7:11 ` João Távora
2021-09-24 15:20 ` [PATCH] Some improvements for cl-flet, and some more akater
2021-09-24 16:22 ` João Távora
2021-09-25 1:28 ` Lars Ingebrigtsen
2021-09-25 8:37 ` João Távora
2021-09-24 20:30 ` [PATCH] Some improvements for cl-flet akater
2021-09-26 6:54 ` Lars Ingebrigtsen [this message]
2021-09-26 12:04 ` akater
2021-09-26 12:36 ` Lars Ingebrigtsen
2021-10-03 3:51 ` Stefan Monnier
2021-10-07 5:02 ` akater
2021-10-07 18:23 ` Stefan Monnier
2021-11-03 12:59 ` akater
2021-11-09 20:37 ` Stefan Monnier
2021-10-09 5:33 ` akater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czovsu7l.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nuclearspace@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).