From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: akater <nuclearspace@gmail.com>, emacs-devel@gnu.org
Subject: Re: Some improvements for cl-flet
Date: Sun, 12 Sep 2021 22:26:31 -0400 [thread overview]
Message-ID: <jwvtuiprzfc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y281cowz.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Sep 2021 02:14:20 +0200")
> (cl-flet ((multilinep (apply-partially #'string-match-p "\n")))
> (pcase something
> ((and (pred stringp) (pred multilinep)) ...)
> ...))
FWIW, this is better written as
(cl-flet ((multilinep (s) (string-match-p "\n" s)))
...)
which is both shorter and more efficient. But there are other cases
where the "simple" form of `cl-flet` is more efficient and the CL
version would need to be of the form
(flet ((FOO (&rest args) (apply BAR args)))
...)
or worse
(let ((bar (BAR BAZ))
(flet ((FOO (&rest args) (apply bar args)))
...)
which would introduce a significant inefficiency and which can be
difficult for the compiler to optimize back to the efficiency of the
code that our `cl-flet` gets without any effort.
Its true that our `cl-flet` introduces an incompatibility with CL's
semantics, but I considered that it's sufficiently minor that the
tradeoff is worth it (as compared to introducing a separate new form).
Stefan
next prev parent reply other threads:[~2021-09-13 2:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 12:51 Some improvements for cl-flet akater
2021-09-11 23:32 ` Michael Heerdegen
2021-09-12 3:35 ` akater
2021-09-12 15:38 ` Stefan Monnier
2021-09-13 0:14 ` Michael Heerdegen
2021-09-13 2:26 ` Stefan Monnier [this message]
2021-10-07 2:32 ` akater
2021-10-07 18:03 ` Stefan Monnier
2021-10-08 21:57 ` Richard Stallman
2021-10-09 5:23 ` akater
2021-10-09 6:01 ` Michael Heerdegen
2021-10-09 23:37 ` Richard Stallman
2021-10-10 10:41 ` Po Lu
2021-10-10 20:27 ` João Távora
2021-10-10 21:57 ` Stefan Monnier
2021-10-11 0:45 ` [External] : " Drew Adams
2021-10-11 21:16 ` Richard Stallman
2021-10-11 21:26 ` João Távora
2021-10-12 22:42 ` Richard Stallman
2021-10-12 0:05 ` Po Lu
2021-10-12 0:29 ` Robin Tarsiger
2021-10-12 22:43 ` Richard Stallman
2021-10-09 23:33 ` Richard Stallman
2021-10-09 23:33 ` Richard Stallman
2021-10-14 4:00 ` Michael Heerdegen
2021-09-23 22:37 ` [PATCH] " akater
2021-09-23 22:41 ` akater
2021-09-24 7:11 ` João Távora
2021-09-24 15:20 ` [PATCH] Some improvements for cl-flet, and some more akater
2021-09-24 16:22 ` João Távora
2021-09-25 1:28 ` Lars Ingebrigtsen
2021-09-25 8:37 ` João Távora
2021-09-24 20:30 ` [PATCH] Some improvements for cl-flet akater
2021-09-26 6:54 ` Lars Ingebrigtsen
2021-09-26 12:04 ` akater
2021-09-26 12:36 ` Lars Ingebrigtsen
2021-10-03 3:51 ` Stefan Monnier
2021-10-07 5:02 ` akater
2021-10-07 18:23 ` Stefan Monnier
2021-11-03 12:59 ` akater
2021-11-09 20:37 ` Stefan Monnier
2021-10-09 5:33 ` akater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtuiprzfc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=nuclearspace@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).