unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ruijie@netyu.xyz,  casouri@gmail.com,  emacs-devel@gnu.org
Subject: Re: Code quality of some -ts-mode major modes
Date: Fri, 17 Mar 2023 16:53:54 +0000	[thread overview]
Message-ID: <87cz57xqsd.fsf@posteo.net> (raw)
In-Reply-To: <831qlne3oe.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Mar 2023 18:35:45 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: ruijie@netyu.xyz,  casouri@gmail.com,  emacs-devel@gnu.org
>> Date: Fri, 17 Mar 2023 15:49:15 +0000
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> I don't know of any language with multiple independent implementations
>> >
>> > I do.  Indeed, most have just one.  But not all.
>> 
>> Could you give me an example that I could try out?
>
> One example I know of is sql.  I think there's at least one other, but
> I don't remember which one.

For posterity, I'll just mentioned that I managed to find two:

- https://github.com/DerekStride/tree-sitter-sql ("general/permissive")
- https://github.com/m-novikov/tree-sitter-sql ("focus on postgresql")

>> > No you are mistaken.  We do want this to signal an error if
>> > tree-sitter is not compiled in or the grammar is not available.
>> 
>> But it doesn't, or am I completely oblivious that
>> 
>>   (treesit-ready-p 'something-i-just-made-up)
>> 
>> just displays a warning?
>
> I'm not sure I understand the question.  Are you saying that the above
> is silent, or are you saying that it pops up a warning instead of
> signaling an error?  If the latter, this is the intended behavior;
> sorry for confusingly saying it should error out.

The latter -- that also explains my confusion.



  reply	other threads:[~2023-03-17 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 10:08 Code quality of some -ts-mode major modes Philip Kaludercic
2023-03-17 10:29 ` Ruijie Yu via Emacs development discussions.
2023-03-17 11:52   ` Eli Zaretskii
2023-03-17 12:37   ` Philip Kaludercic
2023-03-17 13:54     ` Eli Zaretskii
2023-03-17 15:20       ` Philip Kaludercic
2023-03-17 15:31         ` Eli Zaretskii
2023-03-17 15:49           ` Philip Kaludercic
2023-03-17 16:35             ` Eli Zaretskii
2023-03-17 16:53               ` Philip Kaludercic [this message]
2023-03-17 21:45       ` Dmitry Gutov
2023-03-18  5:59         ` Eli Zaretskii
2023-03-17 11:46 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz57xqsd.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ruijie@netyu.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).