From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, Philip Kaludercic <philipk@posteo.net>
Cc: ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org
Subject: Re: Code quality of some -ts-mode major modes
Date: Fri, 17 Mar 2023 23:45:00 +0200 [thread overview]
Message-ID: <34e4a26f-3830-9b8c-a5e0-861a63f5f8bc@yandex.ru> (raw)
In-Reply-To: <83a60beb5a.fsf@gnu.org>
On 17/03/2023 15:54, Eli Zaretskii wrote:
>> I repeat my question from above, if we are ready to link to the
>> grammars, wouldn't it make sense to populate the variable
>> `treesit-language-source-alist' directly?
> No, I don't want to do that, see above for the reasons. (We had this
> discussion about 2 months ago, when the command was added to Emacs.)
FWIW, I had no problems with that conclusion, but then I noticed that we
keep a separate list of sources inside admin/notes/tree-sitter, which
basically contains the same info, as well as all 6 known exceptions to
the general scenario (where in the usual case we can determine
everything just from the name of the language).
If we're going to keep it updated (and we apparently are), why not move
that info to treesit-language-source-alist instead.
We can make it a defcustom, to emphasize that people should update it
whenever they see the data is old.
next prev parent reply other threads:[~2023-03-17 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 10:08 Code quality of some -ts-mode major modes Philip Kaludercic
2023-03-17 10:29 ` Ruijie Yu via Emacs development discussions.
2023-03-17 11:52 ` Eli Zaretskii
2023-03-17 12:37 ` Philip Kaludercic
2023-03-17 13:54 ` Eli Zaretskii
2023-03-17 15:20 ` Philip Kaludercic
2023-03-17 15:31 ` Eli Zaretskii
2023-03-17 15:49 ` Philip Kaludercic
2023-03-17 16:35 ` Eli Zaretskii
2023-03-17 16:53 ` Philip Kaludercic
2023-03-17 21:45 ` Dmitry Gutov [this message]
2023-03-18 5:59 ` Eli Zaretskii
2023-03-17 11:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e4a26f-3830-9b8c-a5e0-861a63f5f8bc@yandex.ru \
--to=dgutov@yandex.ru \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).