From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Code quality of some -ts-mode major modes Date: Fri, 17 Mar 2023 16:53:54 +0000 Message-ID: <87cz57xqsd.fsf@posteo.net> References: <87fsa3g05n.fsf@posteo.net> <87bkkrft9n.fsf@posteo.net> <83a60beb5a.fsf@gnu.org> <87v8izjtf2.fsf@posteo.net> <835yaze6o6.fsf@gnu.org> <87h6ujjs3o.fsf@posteo.net> <831qlne3oe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 17 17:54:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdDLh-0009eF-Ac for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Mar 2023 17:54:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdDKl-0002Lj-Jk; Fri, 17 Mar 2023 12:53:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDKj-0002LI-20 for emacs-devel@gnu.org; Fri, 17 Mar 2023 12:53:37 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDKh-0001Iv-A5 for emacs-devel@gnu.org; Fri, 17 Mar 2023 12:53:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D404C240507 for ; Fri, 17 Mar 2023 17:53:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679072012; bh=aK+g0FNSfLbXrKBtNfhYL57hDgjauSqgyw1BJl3bi+M=; h=From:To:Cc:Subject:Date:From; b=mzCnDIA12hVKRvEoxIgYRYApdOdLUqrHBydlyMaE4te3wkitLyGBlgITqbgh31yEU cikIdL5+BXOHpZC1FjsVIEPG53bhvOOwighdD2kahVK6P9DA3T2f3wR2bK7RQgJxyd WkeOSDWqPFQB0NuKxVbkmY0rU/Qc0g+rEIBNyZBjSjjqP7JnUZzQ6suVwvq/YFqS66 gGQFDcSAuxbHbWAfdx+y6RYJgBMBmv41gQMbIbx4Yl9bwRwvHINT0OS4V9voCmD3RL EJXaszhNnV8I8hPHkOsKjqtLw466dNcp5E49dGgZFEYZlW6xiBywFX3/jof0kMkyXU indkG6n9iSUew== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PdVZM1grvz6tmq; Fri, 17 Mar 2023 17:53:31 +0100 (CET) In-Reply-To: <831qlne3oe.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Mar 2023 18:35:45 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304556 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org >> Date: Fri, 17 Mar 2023 15:49:15 +0000 >> >> Eli Zaretskii writes: >> >> >> I don't know of any language with multiple independent implementations >> > >> > I do. Indeed, most have just one. But not all. >> >> Could you give me an example that I could try out? > > One example I know of is sql. I think there's at least one other, but > I don't remember which one. For posterity, I'll just mentioned that I managed to find two: - https://github.com/DerekStride/tree-sitter-sql ("general/permissive") - https://github.com/m-novikov/tree-sitter-sql ("focus on postgresql") >> > No you are mistaken. We do want this to signal an error if >> > tree-sitter is not compiled in or the grammar is not available. >> >> But it doesn't, or am I completely oblivious that >> >> (treesit-ready-p 'something-i-just-made-up) >> >> just displays a warning? > > I'm not sure I understand the question. Are you saying that the above > is silent, or are you saying that it pops up a warning instead of > signaling an error? If the latter, this is the intended behavior; > sorry for confusingly saying it should error out. The latter -- that also explains my confusion.