From: bird <sbaugh@catern.com>
To: Elijah G <eg642616@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Spencer Baugh <sbaugh@janestreet.com>,
philipk@posteo.net, emacs-devel@gnu.org,
Po Lu <luangruo@yahoo.com>
Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin
Date: Sun, 17 Mar 2024 18:43:52 +0000 (UTC) [thread overview]
Message-ID: <87cyrsitqw.fsf@catern.com> (raw)
In-Reply-To: <CACnP4N+R+uc6XNM=J6zj5ZHJwrLciykVWXZoZ7BGX8O3KTTwmw@mail.gmail.com> (Elijah G.'s message of "Sun, 17 Mar 2024 11:34:50 -0600")
Elijah G <eg642616@gmail.com> writes:
> On Sun, Mar 17, 2024 at 10:44 AM bird <sbaugh@catern.com> wrote:
>> Elijah, could you say more about your setup?
>>
>> - You mentioned you already have a left margin configured; what is
>> displayed in that margin? Is it anything other than flymake/flycheck
>> indicators?
>
> Yes, it is dape-mode, in terminal dape is automatically configured for
> display breakpoints in left-margin, however the error indicators can appear
> next to breakpoint or even hide it if left-margin-width is less than 1.
> This can also apply to other packages that can use margins like
> git-gutter, et cetera.
I see. Wouldn't the margin-based indicator conflict with these
packages, then?
>> - Is there some reason that seeing the indicators is especially
>> important for you? Does it communicate information not already
>> carried by the face?
>
> It is due that the fringes are too small in HIDPI screens, i know
> I can change it to a bigger fringe bitmap and increase fringe width size,
> however this is a problem when increasing and decreasing text size.
Oh, so the motivation for this patch is actually for hidpi support in
graphical frames, not support in terminal frames?
I see that there are a number of bugs about fringes not being scaled for
hidpi screens on X... that's unfortunate. Especially relevant is
bug#37932.
Po Lu, any comments about supporting hidpi fringes on X? Is that
fundamentally hard, or is it just a matter of writing some code which
does scaling?
Even a basic, partial implementation of hidpi fringes would be very
good, I think. Without that, perhaps flymake should use margins instead
of fringes even on graphical frames. hidpi screens are increasingly
common, after all.
next prev parent reply other threads:[~2024-03-17 18:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 23:18 [PATCH] Flymake Support Indicator Errors in Margin Elijah G
2024-03-12 9:24 ` Philip Kaludercic
2024-03-12 17:22 ` Elijah G
2024-03-13 12:18 ` Eli Zaretskii
2024-03-14 1:50 ` Elijah G
2024-03-14 11:05 ` Eli Zaretskii
2024-03-14 11:28 ` João Távora
2024-03-14 15:35 ` Elijah G
2024-03-16 11:10 ` Eli Zaretskii
2024-03-17 16:44 ` bird
2024-03-17 17:01 ` Eli Zaretskii
2024-03-17 17:34 ` Elijah G
2024-03-17 18:43 ` bird [this message]
2024-03-17 19:21 ` Elijah G
2024-03-25 1:46 ` Elijah G
2024-03-27 0:13 ` sbaugh
2024-03-27 0:36 ` Elijah G
2024-03-27 21:29 ` Elijah G
2024-03-28 6:01 ` Eli Zaretskii
2024-03-28 17:34 ` Elijah G
2024-04-06 11:36 ` Eli Zaretskii
2024-03-28 7:30 ` Juri Linkov
2024-03-28 17:44 ` Elijah G
2024-04-06 11:35 ` Eli Zaretskii
2024-04-06 20:14 ` Elijah G
2024-04-07 5:47 ` Eli Zaretskii
2024-04-07 17:20 ` Elijah G
2024-04-18 9:10 ` Eli Zaretskii
2024-03-19 7:03 ` Augusto Stoffel
2024-03-17 17:49 ` Elijah G
2024-03-19 7:04 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyrsitqw.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=eg642616@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=philipk@posteo.net \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).