From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: bird Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin Date: Sun, 17 Mar 2024 18:43:52 +0000 (UTC) Message-ID: <87cyrsitqw.fsf@catern.com> References: <87r0gfajlh.fsf@posteo.net> <868r2mtjdk.fsf@gnu.org> <86msr19ipu.fsf@gnu.org> <864jd677qh.fsf@gnu.org> <87jzm0iza9.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Spencer Baugh , philipk@posteo.net, emacs-devel@gnu.org, Po Lu To: Elijah G Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 17 19:44:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlvV1-0003Ij-Cb for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Mar 2024 19:44:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlvUH-0006i5-At; Sun, 17 Mar 2024 14:44:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlvUF-0006ht-Aq for emacs-devel@gnu.org; Sun, 17 Mar 2024 14:43:59 -0400 Original-Received: from s.wfbtzhsv.outbound-mail.sendgrid.net ([159.183.224.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlvUD-0007la-EV for emacs-devel@gnu.org; Sun, 17 Mar 2024 14:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=msqht+uaqa71VSVv8nVxOOMDYEI2crqo0NQji/xWLHs=; b=uXOXYaJCSVecAR2w4e+wYN2l8rCFQLI7AoFEurNbSJ2XH+UiPitd58kM6StYd4ikWHTX uNcZVjKz88XKr3dOFuJMAAfC0oVprfgOGPkMR4mT9QvExVZSEr5Z6wT0whMFkoIGIhTFJR CmesNyxuYcgGO1/pXMdWhB/IzyP9Pf4BZoo9VhpbVO9qXUyY9V+ia+5lSXV3lKJyru4jib IxgXCfZRYs8tT42mbK/CKeVw8BWqTn2He91a5ITH+lTQv13iJkNGGMMFOovjFULFeMZXAp z7GxI/od6AM4cRjoES0f6eDhQR3+hacDaCSLOucn8CBWXHv/oJXynyMMGBolCTlA== Original-Received: by filterdrecv-58bf8c68ff-hkslt with SMTP id filterdrecv-58bf8c68ff-hkslt-1-65F739E8-1 2024-03-17 18:43:52.037331306 +0000 UTC m=+1108150.936778698 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-23 (SG) with ESMTP id T9eoziv6RjqYPlZ0LDD5dA Sun, 17 Mar 2024 18:43:51.904 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=127.0.0.1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gmail.com Original-Received: from localhost (localhost [127.0.0.1]) by earth.catern.com (Postfix) with ESMTPSA id 6063E624F5; Sun, 17 Mar 2024 14:43:51 -0400 (EDT) In-Reply-To: (Elijah G.'s message of "Sun, 17 Mar 2024 11:34:50 -0600") X-SG-EID: =?us-ascii?Q?u001=2EbKTm6BaPeP40a=2F4nDT+Cqmx+wegHgiCBeYsPHjNWZ7i=2FC7zpxrSDM=2FV9o?= =?us-ascii?Q?+kBkt6T7CApiiFgrZgaqBz=2FKbjKL3lrxdGxf+cr?= =?us-ascii?Q?0jCGlXLuSVh++66pkYd6MZYUW46dW4qPP+e6RPA?= =?us-ascii?Q?0XfFpUYXLTqbzKlE27LNRG2V3iJOMIMtnA8TgDF?= =?us-ascii?Q?upXiMWju=2FjCiCQr6zgmmvk0jDTaZdNkif3J6ABQ?= =?us-ascii?Q?IBUbliqQbIHRhJq5VEJC3M=3D?= X-Entity-ID: u001.oW4JupFKOzCccZAQN2OOFQ== Received-SPF: pass client-ip=159.183.224.104; envelope-from=bounces+21787432-489d-emacs-devel=gnu.org@em8926.catern.com; helo=s.wfbtzhsv.outbound-mail.sendgrid.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317149 Archived-At: Elijah G writes: > On Sun, Mar 17, 2024 at 10:44=E2=80=AFAM bird wrote: >> Elijah, could you say more about your setup? >> >> - You mentioned you already have a left margin configured; what is >> displayed in that margin? Is it anything other than flymake/flycheck >> indicators? > > Yes, it is dape-mode, in terminal dape is automatically configured for > display breakpoints in left-margin, however the error indicators can appe= ar > next to breakpoint or even hide it if left-margin-width is less than 1. > This can also apply to other packages that can use margins like > git-gutter, et cetera. I see. Wouldn't the margin-based indicator conflict with these packages, then? >> - Is there some reason that seeing the indicators is especially >> important for you? Does it communicate information not already >> carried by the face? > > It is due that the fringes are too small in HIDPI screens, i know > I can change it to a bigger fringe bitmap and increase fringe width size, > however this is a problem when increasing and decreasing text size. Oh, so the motivation for this patch is actually for hidpi support in graphical frames, not support in terminal frames? I see that there are a number of bugs about fringes not being scaled for hidpi screens on X... that's unfortunate. Especially relevant is bug#37932. Po Lu, any comments about supporting hidpi fringes on X? Is that fundamentally hard, or is it just a matter of writing some code which does scaling? Even a basic, partial implementation of hidpi fringes would be very good, I think. Without that, perhaps flymake should use margins instead of fringes even on graphical frames. hidpi screens are increasingly common, after all.