unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Elijah G <eg642616@gmail.com>
To: bird <sbaugh@catern.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Spencer Baugh <sbaugh@janestreet.com>,
	joaotavora@gmail.com, philipk@posteo.net, emacs-devel@gnu.org
Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin
Date: Sun, 17 Mar 2024 11:49:19 -0600	[thread overview]
Message-ID: <CACnP4NKa6oVFS47HQbBjpZm5w3GFsDHaWrad5P=OHd+jdbiZjw@mail.gmail.com> (raw)
In-Reply-To: <87jzm0iza9.fsf@catern.com>

On Sun, Mar 17, 2024 at 10:44 AM bird <sbaugh@catern.com> wrote:
> - The current version of Elijah's patch requires the user to explicitly
>   configure left-margin-width (or right-margin-width) to non-zero if
>   they want the indicators to appear; the margins are not automatically
>   grown, unlike in gdb-put-breakpoint-icon.

If you all like, I can update the patch to implement something like that.

> - If it's just about making diagnostics more visible, there are various
>   things we could do, like displaying an indicator inline with the text
>   which has the diagnostic, or highlighting the entire line containing
>   the diagnostic.

I was thinking of implementing things like that in separated patches.

Also as Eli wrote, I only expect to make this as an optional feature.



  parent reply	other threads:[~2024-03-17 17:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 23:18 [PATCH] Flymake Support Indicator Errors in Margin Elijah G
2024-03-12  9:24 ` Philip Kaludercic
2024-03-12 17:22   ` Elijah G
2024-03-13 12:18     ` Eli Zaretskii
2024-03-14  1:50       ` Elijah G
2024-03-14 11:05         ` Eli Zaretskii
2024-03-14 11:28           ` João Távora
2024-03-14 15:35           ` Elijah G
2024-03-16 11:10             ` Eli Zaretskii
2024-03-17 16:44               ` bird
2024-03-17 17:01                 ` Eli Zaretskii
2024-03-17 17:34                 ` Elijah G
2024-03-17 18:43                   ` bird
2024-03-17 19:21                     ` Elijah G
2024-03-25  1:46                       ` Elijah G
2024-03-27  0:13                         ` sbaugh
2024-03-27  0:36                           ` Elijah G
2024-03-27 21:29                           ` Elijah G
2024-03-28  6:01                             ` Eli Zaretskii
2024-03-28 17:34                               ` Elijah G
2024-04-06 11:36                                 ` Eli Zaretskii
2024-03-28  7:30                             ` Juri Linkov
2024-03-28 17:44                               ` Elijah G
2024-04-06 11:35                             ` Eli Zaretskii
2024-04-06 20:14                               ` Elijah G
2024-04-07  5:47                                 ` Eli Zaretskii
2024-04-07 17:20                                   ` Elijah G
2024-04-18  9:10                                     ` Eli Zaretskii
2024-03-19  7:03                   ` Augusto Stoffel
2024-03-17 17:49                 ` Elijah G [this message]
2024-03-19  7:04                   ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACnP4NKa6oVFS47HQbBjpZm5w3GFsDHaWrad5P=OHd+jdbiZjw@mail.gmail.com' \
    --to=eg642616@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=philipk@posteo.net \
    --cc=sbaugh@catern.com \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).