From: Philip Kaludercic <philipk@posteo.net>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: Gregory Heytings <gregory@heytings.org>, Madhu <enometh@meer.net>,
emacs-devel@gnu.org
Subject: Re: Adding transient to Emacs core
Date: Tue, 27 Apr 2021 15:21:26 +0000 [thread overview]
Message-ID: <87bl9z3g95.fsf@posteo.net> (raw)
In-Reply-To: <875z08lyoz.fsf@bernoul.li> (Jonas Bernoulli's message of "Tue, 27 Apr 2021 14:05:48 +0200")
Jonas Bernoulli <jonas@bernoul.li> writes:
> Any Emacs command can be added as the suffix of a transient prefix
> command, for example:
>
> (transient-define-prefix my-buffer-commands ()
> "Do stuff to buffers."
> [:description (lambda () (format "Act on current buffer (%s)" (current-buffer)))
> ("k" "kill the current buffer" kill-this-buffer)])
>
> (global-set-key [f1] 'my-buffer-commands)
I just tried this out, and it seems that transient it very different
compared to magit-popup, that powers my local version of magit (from
MELPA Stable).
I am uncertain how I feel about this, as it seems to be something
completely different than what I was thinking about all the time.
At the same time it does not seem obvious why, especially with transient
menus that may contain a lot of options (say a ffmpeg interface)
shouldn't be able to use the entire frame. Especially from a user
perspective.
> If the selected window were repurposed to display transient's buffer,
> then that would change what buffer is the current buffer and it would
> become impossible to act on the buffer that was previously the current
> buffer or on "the thing under the cursor" in that buffer.
What do you mean by "what buffer is the current buffer"? I am somewhat
confused by what you are trying to say here.
> Re-purposing the selected window would massively reduce the usefulness
> of a huge number of commands or even make them completely useless.
Again, I do not see how this follows? My verison of Magit has
magit-display-buffer-function, that allows me to display the buffer in
the selected window, with no loss of functionality. What does transient
do or need that prevents this?
--
Philip K.
next prev parent reply other threads:[~2021-04-27 15:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 15:51 Adding transient to Emacs core Jonas Bernoulli
2021-04-19 16:07 ` Eli Zaretskii
2021-04-20 12:39 ` Jonas Bernoulli
2021-04-20 13:01 ` Eli Zaretskii
2021-04-20 16:53 ` Jonas Bernoulli
2021-04-20 17:22 ` Kévin Le Gouguec
2021-04-20 18:05 ` Stefan Kangas
2021-04-20 13:19 ` Dmitry Gutov
2021-04-20 16:59 ` Jonas Bernoulli
2021-04-20 17:07 ` Dmitry Gutov
2021-04-26 2:30 ` Madhu
2021-04-26 11:51 ` Eli Zaretskii
2021-04-26 12:54 ` Philip Kaludercic
2021-04-26 13:07 ` Eli Zaretskii
2021-04-26 17:56 ` Madhu
2021-04-26 18:12 ` Eli Zaretskii
[not found] ` <20210427.073903.1397547038526168961.enometh@meer.net>
2021-04-27 2:36 ` Eli Zaretskii
2021-04-26 13:27 ` Jonas Bernoulli
2021-04-26 17:33 ` Madhu
2021-04-26 17:44 ` Eli Zaretskii
2021-04-26 17:52 ` Stefan Monnier
2021-04-27 2:03 ` Madhu
2021-04-27 3:29 ` Stefan Monnier
2021-04-27 9:00 ` Jonas Bernoulli
2021-04-27 10:51 ` Philip Kaludercic
2021-04-27 11:01 ` Gregory Heytings
2021-04-27 12:05 ` Jonas Bernoulli
2021-04-27 12:26 ` Gregory Heytings
2021-04-27 15:24 ` Jonas Bernoulli
2021-04-27 15:21 ` Philip Kaludercic [this message]
2021-04-27 21:11 ` Jonas Bernoulli
2021-04-27 12:08 ` martin rudalics
2021-04-27 15:03 ` Jonas Bernoulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl9z3g95.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=enometh@meer.net \
--cc=gregory@heytings.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).