unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Madhu <enometh@meer.net>
To: monnier@iro.umontreal.ca
Cc: emacs-devel@gnu.org
Subject: Re: Adding transient to Emacs core
Date: Tue, 27 Apr 2021 07:33:17 +0530 (IST)	[thread overview]
Message-ID: <20210427.073317.990947448424068192.enometh@meer.net> (raw)
In-Reply-To: <jwvwnspos54.fsf-monnier+emacs@gnu.org>

*  Stefan Monnier <monnier@iro.umontreal.ca> <jwvwnspos54.fsf-monnier+emacs@gnu.org>
Wrote on Mon, 26 Apr 2021 13:52:49 -0400

>> If the package does not support use display-buffer according to the
>> design of display-buffer, I maintain it will have a negative impact if
>> adopted in the core and one is constrained to use it (instead of
>> keeping it optional)

> In my experience, among the packages that have to display something
> (as opposed to your usual major-mode which only provides commands to
> navigate and edit text), very few correctly deal with all possible
> `display-buffer-alist` customizations.  The vast majority assumes a
> single-frame setup and break in random way in less conventional
> situations.
>
> So if transient.el misbehaves in some of those cases, it's in pretty
> good company.

And I have the option of not being forced to use those packages when
dealing with emacs.

> In the transient.el API the only thing that could inherently cause
> problem, AFAICT is the fact that it relies on being able to
> display a "sizeable" amount of information to the user, but it's hard to

No this is pretty fundamental. The designer of the transient prompt
can make the prompt big enough to trigger the situations where it
fails.

> imagine a comparable feature that doesn't make similar assumptions, and
> it's hard to imagine a situation where there's really no way to make
> it work.
>
> So any problem it might suffer should be a mere "implementation issue"
> that can be fixed without impacting the packages which rely on it.

Except when they can't because of funamental incompatible assumptions.

(Note I am responding at the same level of generality as your post)

If a core package which worked fine is now modified to use a package
which you introduce and the new package and cannot be used in certain
circumstances (that the developer of the new package has not or cannot
consider) I maintain that the new package destroys existing value -
and if that is the explict intent I hope it is made explicit.




  reply	other threads:[~2021-04-27  2:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 15:51 Adding transient to Emacs core Jonas Bernoulli
2021-04-19 16:07 ` Eli Zaretskii
2021-04-20 12:39   ` Jonas Bernoulli
2021-04-20 13:01     ` Eli Zaretskii
2021-04-20 16:53       ` Jonas Bernoulli
2021-04-20 17:22         ` Kévin Le Gouguec
2021-04-20 18:05           ` Stefan Kangas
2021-04-20 13:19 ` Dmitry Gutov
2021-04-20 16:59   ` Jonas Bernoulli
2021-04-20 17:07     ` Dmitry Gutov
2021-04-26  2:30 ` Madhu
2021-04-26 11:51   ` Eli Zaretskii
2021-04-26 12:54     ` Philip Kaludercic
2021-04-26 13:07       ` Eli Zaretskii
2021-04-26 17:56     ` Madhu
2021-04-26 18:12       ` Eli Zaretskii
     [not found]         ` <20210427.073903.1397547038526168961.enometh@meer.net>
2021-04-27  2:36           ` Eli Zaretskii
2021-04-26 13:27   ` Jonas Bernoulli
2021-04-26 17:33     ` Madhu
2021-04-26 17:44       ` Eli Zaretskii
2021-04-26 17:52       ` Stefan Monnier
2021-04-27  2:03         ` Madhu [this message]
2021-04-27  3:29           ` Stefan Monnier
2021-04-27  9:00       ` Jonas Bernoulli
2021-04-27 10:51         ` Philip Kaludercic
2021-04-27 11:01         ` Gregory Heytings
2021-04-27 12:05           ` Jonas Bernoulli
2021-04-27 12:26             ` Gregory Heytings
2021-04-27 15:24               ` Jonas Bernoulli
2021-04-27 15:21             ` Philip Kaludercic
2021-04-27 21:11               ` Jonas Bernoulli
2021-04-27 12:08         ` martin rudalics
2021-04-27 15:03           ` Jonas Bernoulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427.073317.990947448424068192.enometh@meer.net \
    --to=enometh@meer.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).