From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Adding transient to Emacs core Date: Tue, 27 Apr 2021 15:21:26 +0000 Message-ID: <87bl9z3g95.fsf@posteo.net> References: <87czuqi86o.fsf@bernoul.li> <87pmyhdvla.fsf@bernoul.li> <20210426.230318.88708181443886760.enometh@meer.net> <878s54m7ae.fsf@bernoul.li> <875z08lyoz.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Madhu , emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 17:22:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbPY9-0009jF-9H for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 17:22:57 +0200 Original-Received: from localhost ([::1]:53096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbPY8-0000iD-Bn for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 11:22:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbPWp-0007o6-56 for emacs-devel@gnu.org; Tue, 27 Apr 2021 11:21:35 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:52789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbPWn-0006SE-0P for emacs-devel@gnu.org; Tue, 27 Apr 2021 11:21:34 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 67D0824002A for ; Tue, 27 Apr 2021 17:21:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619536888; bh=vmYtUJjuDJXBzzgXvAKsakI8yis07Rsqy7uNyR6+4A8=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=h3Yrm8EAlXmUb9PW0TEduoVwR6U7pIfQ1tdK2W8gMPvL51KkIA4jmUMr0Pbrx4pRj v2QiGC626wlnXw46Z83NYtZrdvouKNXPhEtCLRSGr8amkzgPhccWExlCT+DX25Lsf+ YLK8iU8TGm23xVxhpOO3VYAnxXLbrhf5SLTQGjk56DZbtRHeO73LL3Y2SLqr9VeSTl kBTYmkmqXoJaSKlaqlMO6N7K3LfAU9N0MZ+LQ0S3kJSo2MDX+a78IwEgoYAuqcpWQg +RKnrYHzljR5vyCgfbWQI0ZMRwiv3ch8+mPjxARTClemtBw/7ub+peicLa41PIrz2+ FudIeNj/ve7bA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FV58729F0z9rxm; Tue, 27 Apr 2021 17:21:27 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <875z08lyoz.fsf@bernoul.li> (Jonas Bernoulli's message of "Tue, 27 Apr 2021 14:05:48 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268533 Archived-At: Jonas Bernoulli writes: > Any Emacs command can be added as the suffix of a transient prefix > command, for example: > > (transient-define-prefix my-buffer-commands () > "Do stuff to buffers." > [:description (lambda () (format "Act on current buffer (%s)" (current-buffer))) > ("k" "kill the current buffer" kill-this-buffer)]) > > (global-set-key [f1] 'my-buffer-commands) I just tried this out, and it seems that transient it very different compared to magit-popup, that powers my local version of magit (from MELPA Stable). I am uncertain how I feel about this, as it seems to be something completely different than what I was thinking about all the time. At the same time it does not seem obvious why, especially with transient menus that may contain a lot of options (say a ffmpeg interface) shouldn't be able to use the entire frame. Especially from a user perspective. > If the selected window were repurposed to display transient's buffer, > then that would change what buffer is the current buffer and it would > become impossible to act on the buffer that was previously the current > buffer or on "the thing under the cursor" in that buffer. What do you mean by "what buffer is the current buffer"? I am somewhat confused by what you are trying to say here. > Re-purposing the selected window would massively reduce the usefulness > of a huge number of commands or even make them completely useless. Again, I do not see how this follows? My verison of Magit has magit-display-buffer-function, that allows me to display the buffer in the selected window, with no loss of functionality. What does transient do or need that prevents this? -- Philip K.