Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals

Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals

[Stefan Monnier]

>    The usual purpose of the terminal-specific library is to map the
>  escape sequences used by the terminal's function keys onto more
>  meaningful names, using @code{input-decode-map} (or
> -@code{function-key-map} before it).  See the file
> +@code{local-function-key-map} before it).

Actually, they should mostly use `input-decode-map` instead nowadays (the
difference is that `input-decode-map`'s remapping is applied
unconditionally, where `(local-)function-key-map`'s remapping is only
applied when there's no normal keybinding).

>  @smallexample
>  ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.}
> -(define-key function-key-map [kp-enter] [?\C-j])
> +(define-key local-function-key-map [kp-enter] [?\C-j])

This remapping should probably be applied to any terminal that has
a kp-enter key, so I think the change is for the worse.

> @@ -190,7 +190,7 @@ key sequence, providing the @acronym{ASCII} key sequence prefix is
>  already known by Emacs to be a prefix.  As a result of providing this
>  support, some terminal/keyboard/window system configurations, which
>  don't have a complete set of sensible function key bindings built into
> -Emacs in @code{function-key-map}, can still be configured for use with
> +Emacs in @code{local-function-key-map}, can still be configured for use with

This one should also refer to `input-decode-map`.

> -(define-key function-key-map [M-@key{TAB}] [?\M-\t])
> +(define-key local-function-key-map [M-@key{TAB}] [?\M-\t])
[...]
> -(define-key function-key-map [f11] [?\e])
> +(define-key local-function-key-map [f11] [?\e])

As above, I think these changes are for the worse.


        Stefan

Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Actually, they should mostly use `input-decode-map` instead nowadays (the
> difference is that `input-decode-map`'s remapping is applied
> unconditionally, where `(local-)function-key-map`'s remapping is only
> applied when there's no normal keybinding).

I've now changed the two instances to refer to input-decode-map (only).

>>  @smallexample
>>  ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.}
>> -(define-key function-key-map [kp-enter] [?\C-j])
>> +(define-key local-function-key-map [kp-enter] [?\C-j])
>
> This remapping should probably be applied to any terminal that has
> a kp-enter key, so I think the change is for the worse.

Makes sense...  but should we then change the bit in the manual that
says:

@code{local-function-key-map} inherits from @code{function-key-map},
but the latter should not be used directly.

Perhaps we should change that to something that says more explicitly
what the effect of using function-key-map is?  Something like "which
should only be used if you want the changes in all terminals"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals

[Stefan Monnier]

> Perhaps we should change that to something that says more explicitly
> what the effect of using function-key-map is?  Something like "which
> should only be used if you want the changes in all terminals"?

Sounds right, yes,


        Stefan

Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Perhaps we should change that to something that says more explicitly
>> what the effect of using function-key-map is?  Something like "which
>> should only be used if you want the changes in all terminals"?
>
> Sounds right, yes,

I've now done this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no