From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Date: Tue, 23 Jul 2019 15:57:12 -0400 Message-ID: References: <20190723171714.15080.69466@vcs0.savannah.gnu.org> <20190723171715.8F064210EC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119964"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 21:57:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hq0uf-000V6t-S9 for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 21:57:29 +0200 Original-Received: from localhost ([::1]:47128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hq0ue-00016s-Cv for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 15:57:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36973) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hq0uV-00015M-QQ for emacs-devel@gnu.org; Tue, 23 Jul 2019 15:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hq0uU-0000IJ-Nl for emacs-devel@gnu.org; Tue, 23 Jul 2019 15:57:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hq0uU-0000Hc-JW for emacs-devel@gnu.org; Tue, 23 Jul 2019 15:57:18 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35ABF100944; Tue, 23 Jul 2019 15:57:16 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 806FF10059A; Tue, 23 Jul 2019 15:57:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1563911834; bh=Pcqw+l52FJUMoO4OfNiT9ewe2WOyhqNCjN2K/gqI70Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ctJT+deHig4N5mBDyutoKC+ytShYqW6B4Ylqdo62kkNBV0N96wZubTIHbkBkx4CBU sGA4VO6W/x5Nv8G+7ws8KpIH/wdCfgm/L8Vkt0rD8wR2E3x5afT63MAztbGBdizagF /Yd6mp+tay1j2agBP5sMN9S3xN/6Vz6cIoPVm6p6/VLo8DVfnkgZ8bYmz5n24JqSB1 b7ee9q8aQDghgVXxGvKVaPzu8iiB7dLmd1pNxkX9rNXrqJlUhgXtebft6t1A72yQXy J57ImNZ+XyofK+39McuqmygHsYdgHNhYgq06A79GEBwfTUWTW9BaTFTeeicbQRjbXK X+oRU2mk6mgdA== Original-Received: from alfajor (unknown [216.154.19.233]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD53A1214CD; Tue, 23 Jul 2019 15:57:13 -0400 (EDT) In-Reply-To: <20190723171715.8F064210EC@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 23 Jul 2019 13:17:15 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238858 Archived-At: > The usual purpose of the terminal-specific library is to map the > escape sequences used by the terminal's function keys onto more > meaningful names, using @code{input-decode-map} (or > -@code{function-key-map} before it). See the file > +@code{local-function-key-map} before it). Actually, they should mostly use `input-decode-map` instead nowadays (the difference is that `input-decode-map`'s remapping is applied unconditionally, where `(local-)function-key-map`'s remapping is only applied when there's no normal keybinding). > @smallexample > ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.} > -(define-key function-key-map [kp-enter] [?\C-j]) > +(define-key local-function-key-map [kp-enter] [?\C-j]) This remapping should probably be applied to any terminal that has a kp-enter key, so I think the change is for the worse. > @@ -190,7 +190,7 @@ key sequence, providing the @acronym{ASCII} key sequence prefix is > already known by Emacs to be a prefix. As a result of providing this > support, some terminal/keyboard/window system configurations, which > don't have a complete set of sensible function key bindings built into > -Emacs in @code{function-key-map}, can still be configured for use with > +Emacs in @code{local-function-key-map}, can still be configured for use with This one should also refer to `input-decode-map`. > -(define-key function-key-map [M-@key{TAB}] [?\M-\t]) > +(define-key local-function-key-map [M-@key{TAB}] [?\M-\t]) [...] > -(define-key function-key-map [f11] [?\e]) > +(define-key local-function-key-map [f11] [?\e]) As above, I think these changes are for the worse. Stefan