unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Kangas <stefankangas@gmail.com>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [External] : Re: master 927b885 1/3: Disable filtering of commands in M-x completion
Date: Thu, 18 Feb 2021 19:22:12 +0200	[thread overview]
Message-ID: <87a6s1e3a3.fsf@mail.linkov.net> (raw)
In-Reply-To: <SA2PR10MB4474BCAA9FCF73649B64B76AF3859@SA2PR10MB4474.namprd10.prod.outlook.com> (Drew Adams's message of "Thu, 18 Feb 2021 16:25:45 +0000")

>> > (defun foo (&optional beg end)
>> >   (interactive "r")
>> >   (message "FOO"))
>>
>> Yes, I'm sure.  'M-x foo RET' without an active region
>> raises an error:
>>   command-execute: The mark is not active now
>
> I don't see that in Emacs 27.1 or prior (with
> `emacs -Q').  Is this perhaps new for 28?
> If so, why would we do that?

It raises an error because the value of
mark-even-if-inactive was changed to nil,
so the region exists only when explicitly activated.

>> This means that more complex interactive specs
>> need manual tagging using a new tag:
>>   (declare (predicate (use-region-p)))
>
> But even that won't handle arbitrary `interactive'
> sexps, right?

`declare' could use the same logic used in `interactive'
that detects region boundaries.

>> Same tag:
>>   (declare (predicate (not buffer-read-only)))
>
> And what about commands that might be usable
> interactively, but whose `interactive' spec
> doesn't encapsulate all that's involved?  In that
> case, manual addition of a declaration will need
> to look into the logic of the command body as
> well.  (Admittedly, such commands are uncommon.)

Yes, here it should share the same logic as well.

>> Using a prefix arg for 'C-h f' and 'C-h v' to limit the list
>> of completions would be nice.
>>
>> But I guess M-x can't use a prefix arg to limit completions?
>
> Why do you think so?  `C-u M-x describe-function TAB'
> (with my definition from `help-fns+.el') shows only
> commands as candidates.

The docstring of `execute-extended-command' says:

  To pass a prefix argument to the command you are invoking,
  give a prefix argument to ‘execute-extended-command’.

And indeed `C-u M-x forward-char RET' moves 4 chars forwards.
So you can't use `C-u M-x TAB' to limit the number of completions.
Maybe then use another prefix like `C-x', i.e. `C-x M-x'?
This is similar to how `C-x M-:' combines the prefix `C-x'
to run `repeat-complex-command'.



  reply	other threads:[~2021-02-18 17:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210217165944.26910.26583@vcs0.savannah.gnu.org>
     [not found] ` <20210217165946.030D420DFC@vcs0.savannah.gnu.org>
2021-02-17 19:27   ` master 927b885 1/3: Disable filtering of commands in M-x completion Stefan Kangas
2021-02-17 20:01     ` Juri Linkov
2021-02-17 22:18       ` [External] : " Drew Adams
2021-02-18  9:33         ` Juri Linkov
2021-02-18 16:25           ` Drew Adams
2021-02-18 17:22             ` Juri Linkov [this message]
2021-02-18 18:24               ` Drew Adams
2021-02-18 19:03                 ` Juri Linkov
2021-02-18 19:18                   ` Drew Adams
2021-02-18 19:35                 ` Eli Zaretskii
2021-02-18 19:47                   ` Drew Adams
2021-02-18 19:58                     ` Eli Zaretskii
2021-02-18 20:11                       ` Drew Adams
2021-02-18 20:22                       ` Drew Adams
2021-02-18 20:25                         ` Eli Zaretskii
2021-02-18 20:45                           ` Drew Adams
2021-02-19 13:17                             ` Eli Zaretskii
2021-02-19 17:53                               ` Drew Adams
2021-02-19 18:38                                 ` Eli Zaretskii
2021-02-18 23:15                       ` martin rudalics
2021-02-18 23:32                         ` Drew Adams
2021-02-19  8:37                           ` Eli Zaretskii
2021-02-19 17:42                             ` Drew Adams
2021-02-18 19:38                 ` Eli Zaretskii
2021-02-18 19:49                   ` Drew Adams
2021-02-18 19:58                     ` Eli Zaretskii
2021-02-18 20:26                       ` Drew Adams
2021-02-17 20:04     ` Eli Zaretskii
2021-02-17 20:31       ` Stefan Kangas
2021-02-17 20:12     ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6s1e3a3.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).