From: Dmitry Gutov <dgutov@yandex.ru>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el.
Date: Mon, 03 Dec 2012 03:58:56 +0400 [thread overview]
Message-ID: <878v9groov.fsf@yandex.ru> (raw)
In-Reply-To: <E1Tf2rc-00087q-Kb@vcs.savannah.gnu.org> (Chong Yidong's message of "Sun, 02 Dec 2012 14:06:32 +0800")
Hi Chong,
Chong Yidong <cyd@gnu.org> writes:
> ------------------------------------------------------------
> revno: 111061
> committer: Chong Yidong <cyd@gnu.org>
> branch nick: trunk
> timestamp: Sun 2012-12-02 14:06:32 +0800
> message:
> Fix for bad test in ruby-mode-tests.el.
>
> * automated/ruby-mode-tests.el (ruby-add-log-current-method-examples):
> Don't use loop macro, to allow automated testing to work.
> modified:
> test/ChangeLog
> test/automated/ruby-mode-tests.el
Is there some way to run all tests in automated fashion (which I broke)?
Would it have been better if I 'require'd cl-lib and used the prefixed
version of the macro?
Is it considered okay that you've replaced spaces with tabs?
> === modified file 'test/ChangeLog'
> --- a/test/ChangeLog 2012-11-20 04:24:09 +0000
> +++ b/test/ChangeLog 2012-12-02 06:06:32 +0000
> @@ -1,3 +1,9 @@
> +2012-12-02 Chong Yidong <cyd@gnu.org>
> +
> + * automated/ruby-mode-tests.el
> + (ruby-add-log-current-method-examples): Don't use loop macro, to
> + allow automated testing to work.
> +
> 2012-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
>
> * automated/advice-tests.el (advice-tests--data): Remove.
>
> === modified file 'test/automated/ruby-mode-tests.el'
> --- a/test/automated/ruby-mode-tests.el 2012-11-14 12:17:21 +0000
> +++ b/test/automated/ruby-mode-tests.el 2012-12-02 06:06:32 +0000
> @@ -296,21 +296,23 @@
> (let ((pairs '(("foo" . "#foo")
> ("C.foo" . ".foo")
> ("self.foo" . ".foo"))))
> - (loop for (name . value) in pairs
> - do (with-temp-buffer
> - (insert (ruby-test-string
> - "module M
> + (dolist (pair pairs)
> + (let ((name (car pair))
> + (value (cdr pair)))
> + (with-temp-buffer
> + (insert (ruby-test-string
> + "module M
> | class C
> | def %s
> | end
> | end
> |end"
> - name))
> - (ruby-mode)
> - (search-backward "def")
> - (forward-line)
> - (should (string= (ruby-add-log-current-method)
> - (format "M::C%s" value)))))))
> + name))
> + (ruby-mode)
> + (search-backward "def")
> + (forward-line)
> + (should (string= (ruby-add-log-current-method)
> + (format "M::C%s" value))))))))
>
> (defvar ruby-block-test-example
> (ruby-test-string
next parent reply other threads:[~2012-12-02 23:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Tf2rc-00087q-Kb@vcs.savannah.gnu.org>
2012-12-02 23:58 ` Dmitry Gutov [this message]
2012-12-03 4:13 ` /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el Chong Yidong
2012-12-03 18:45 ` Dmitry Gutov
2012-12-03 19:48 ` Stefan Monnier
2012-12-03 19:55 ` Burton Samograd
2012-12-03 21:03 ` Dmitry Gutov
2012-12-03 21:20 ` Burton Samograd
2012-12-03 21:54 ` Stefan Monnier
2012-12-03 20:00 ` Dmitry Gutov
2012-12-04 8:44 ` Stephen Leake
2012-12-04 14:51 ` Stefan Monnier
2012-12-04 17:55 ` martin rudalics
2012-12-04 18:07 ` Stefan Monnier
2012-12-05 9:41 ` martin rudalics
2012-12-05 14:54 ` Stefan Monnier
2012-12-05 3:49 ` Stephen Leake
2012-12-05 4:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v9groov.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).