From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el. Date: Mon, 03 Dec 2012 03:58:56 +0400 Message-ID: <878v9groov.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354492749 25111 80.91.229.3 (2 Dec 2012 23:59:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Dec 2012 23:59:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 03 00:59:21 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TfJRM-0008HU-N0 for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2012 00:59:16 +0100 Original-Received: from localhost ([::1]:37958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfJRB-0003YC-63 for ged-emacs-devel@m.gmane.org; Sun, 02 Dec 2012 18:59:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfJR9-0003Y7-5C for emacs-devel@gnu.org; Sun, 02 Dec 2012 18:59:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfJR8-0006HB-1C for emacs-devel@gnu.org; Sun, 02 Dec 2012 18:59:03 -0500 Original-Received: from mail-lb0-f169.google.com ([209.85.217.169]:33358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfJR7-0006Gy-Pc; Sun, 02 Dec 2012 18:59:01 -0500 Original-Received: by mail-lb0-f169.google.com with SMTP id gk1so1986273lbb.0 for ; Sun, 02 Dec 2012 15:59:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=agQOuoAEtgfSO435WEJ4Z5BokNlWIXPKAiaSZmGnmJo=; b=iaQjLzraHsqyFB6lBTgr+RGP3BaoxVmGJI1Q7y9Ew+mAK2SdltQyZQDjwao9R1JKB+ RzSlB/ifQVePU6J3ebF/DQExHs0QxV1VUhCfksNgXiF3yI2WM5Cpb0NmGb8IkxdO6c/l TdL3uCN2EuE76vEckMCZ2EHOfQ+CK3dM8wVzlELZ5BS96d24fIrNBWpfDyU5YDoupqb5 FinqDRKCn+gC3FX2Ak/urGTBIXyrK5GRcJ9a7+x+YcMBP51xXnVp2+jgYWdmcj6/c/Wi BlU9KrXCXqssMjdwFbayTZw//9JxGGMf63gNxyxcxRidcKVpvFSMGvdHu8QehIOsI6Cf L1Yg== Original-Received: by 10.112.31.194 with SMTP id c2mr3456478lbi.44.1354492740071; Sun, 02 Dec 2012 15:59:00 -0800 (PST) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id hu6sm4490985lab.13.2012.12.02.15.58.57 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 02 Dec 2012 15:58:58 -0800 (PST) In-Reply-To: (Chong Yidong's message of "Sun, 02 Dec 2012 14:06:32 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155181 Archived-At: Hi Chong, Chong Yidong writes: > ------------------------------------------------------------ > revno: 111061 > committer: Chong Yidong > branch nick: trunk > timestamp: Sun 2012-12-02 14:06:32 +0800 > message: > Fix for bad test in ruby-mode-tests.el. > > * automated/ruby-mode-tests.el (ruby-add-log-current-method-examples): > Don't use loop macro, to allow automated testing to work. > modified: > test/ChangeLog > test/automated/ruby-mode-tests.el Is there some way to run all tests in automated fashion (which I broke)? Would it have been better if I 'require'd cl-lib and used the prefixed version of the macro? Is it considered okay that you've replaced spaces with tabs? > === modified file 'test/ChangeLog' > --- a/test/ChangeLog 2012-11-20 04:24:09 +0000 > +++ b/test/ChangeLog 2012-12-02 06:06:32 +0000 > @@ -1,3 +1,9 @@ > +2012-12-02 Chong Yidong > + > + * automated/ruby-mode-tests.el > + (ruby-add-log-current-method-examples): Don't use loop macro, to > + allow automated testing to work. > + > 2012-11-20 Stefan Monnier > > * automated/advice-tests.el (advice-tests--data): Remove. > > === modified file 'test/automated/ruby-mode-tests.el' > --- a/test/automated/ruby-mode-tests.el 2012-11-14 12:17:21 +0000 > +++ b/test/automated/ruby-mode-tests.el 2012-12-02 06:06:32 +0000 > @@ -296,21 +296,23 @@ > (let ((pairs '(("foo" . "#foo") > ("C.foo" . ".foo") > ("self.foo" . ".foo")))) > - (loop for (name . value) in pairs > - do (with-temp-buffer > - (insert (ruby-test-string > - "module M > + (dolist (pair pairs) > + (let ((name (car pair)) > + (value (cdr pair))) > + (with-temp-buffer > + (insert (ruby-test-string > + "module M > | class C > | def %s > | end > | end > |end" > - name)) > - (ruby-mode) > - (search-backward "def") > - (forward-line) > - (should (string= (ruby-add-log-current-method) > - (format "M::C%s" value))))))) > + name)) > + (ruby-mode) > + (search-backward "def") > + (forward-line) > + (should (string= (ruby-add-log-current-method) > + (format "M::C%s" value)))))))) > > (defvar ruby-block-test-example > (ruby-test-string