From: Dmitry Gutov <dgutov@yandex.ru>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el.
Date: Mon, 03 Dec 2012 22:45:15 +0400 [thread overview]
Message-ID: <50BCF33B.4080809@yandex.ru> (raw)
In-Reply-To: <87ehj7hiy7.fsf@gnu.org>
On 03.12.2012 8:13, Chong Yidong wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> Is there some way to run all tests in automated fashion (which I
>> broke)?
>
> Do `make check' from the top level of the tree.
>
>> Would it have been better if I 'require'd cl-lib and used the prefixed
>> version of the macro?
>
> Sure, that would probably have worked too.
Thanks for the answers.
What about the third question? Last time I've seen a discussion about
whitespace style in Emacs codebase, I think it was somewhat of a
consensus that spaces > tabs (which is also my preference), but doing
whitespace-only commits was declared verboten, so I can't just revert
that part of the change.
next prev parent reply other threads:[~2012-12-03 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Tf2rc-00087q-Kb@vcs.savannah.gnu.org>
2012-12-02 23:58 ` /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el Dmitry Gutov
2012-12-03 4:13 ` Chong Yidong
2012-12-03 18:45 ` Dmitry Gutov [this message]
2012-12-03 19:48 ` Stefan Monnier
2012-12-03 19:55 ` Burton Samograd
2012-12-03 21:03 ` Dmitry Gutov
2012-12-03 21:20 ` Burton Samograd
2012-12-03 21:54 ` Stefan Monnier
2012-12-03 20:00 ` Dmitry Gutov
2012-12-04 8:44 ` Stephen Leake
2012-12-04 14:51 ` Stefan Monnier
2012-12-04 17:55 ` martin rudalics
2012-12-04 18:07 ` Stefan Monnier
2012-12-05 9:41 ` martin rudalics
2012-12-05 14:54 ` Stefan Monnier
2012-12-05 3:49 ` Stephen Leake
2012-12-05 4:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BCF33B.4080809@yandex.ru \
--to=dgutov@yandex.ru \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).